-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): move company.name formats to locales #1279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
- Coverage 99.63% 99.62% -0.02%
==========================================
Files 2154 2160 +6
Lines 239914 240429 +515
Branches 1007 1004 -3
==========================================
+ Hits 239039 239524 +485
- Misses 854 884 +30
Partials 21 21
|
Minozzzi
commented
Aug 18, 2022
Shinigami92
reviewed
Aug 18, 2022
Shinigami92
added
breaking change
Cannot be merged when next version is not a major release
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: company
Something is referring to the company module
s: needs decision
Needs team/maintainer decision
labels
Aug 18, 2022
…1280) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
ST-DDT
requested changes
Aug 18, 2022
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Shinigami92
reviewed
Aug 18, 2022
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
ST-DDT
previously approved these changes
Aug 19, 2022
Shinigami92
requested changes
Aug 19, 2022
…mpany.name with parameter Co-authored-by: Shinigami <chrissi92@hotmail.de>
…mpany.name with parameter Co-authored-by: Shinigami <chrissi92@hotmail.de>
…Minozzzi/faker into refactor/company/formats
…mpany.name with parameter Co-authored-by: Shinigami <chrissi92@hotmail.de>
…Minozzzi/faker into refactor/company/formats
…mpany.name with parameter Co-authored-by: Shinigami <chrissi92@hotmail.de>
…Minozzzi/faker into refactor/company/formats
Guys, I've problems with rebase. I'will close this PR and open another |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Cannot be merged when next version is not a major release
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: company
Something is referring to the company module
s: needs decision
Needs team/maintainer decision
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.