Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): move company.name formats to locales #1279

Closed
wants to merge 50 commits into from

Conversation

Minozzzi
Copy link
Contributor

No description provided.

@Minozzzi Minozzzi requested a review from a team as a code owner August 18, 2022 00:37
@Minozzzi Minozzzi closed this Aug 18, 2022
@Minozzzi Minozzzi reopened this Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #1279 (2ecf7cf) into main (5c10bd7) will decrease coverage by 0.01%.
The diff coverage is 98.99%.

❗ Current head 2ecf7cf differs from pull request most recent head 0e0d3aa. Consider uploading reports for the commit 0e0d3aa to get more accurate results

@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.02%     
==========================================
  Files        2154     2160       +6     
  Lines      239914   240429     +515     
  Branches     1007     1004       -3     
==========================================
+ Hits       239039   239524     +485     
- Misses        854      884      +30     
  Partials       21       21              
Impacted Files Coverage Δ
src/definitions/company.ts 0.00% <0.00%> (ø)
src/definitions/name.ts 0.00% <0.00%> (ø)
src/locales/az/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/cz/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/de/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/de_AT/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/de_CH/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/en_GH/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/es/company/name_patterns.ts 100.00% <ø> (ø)
src/locales/es_MX/company/name_patterns.ts 100.00% <ø> (ø)
... and 70 more

@Shinigami92 Shinigami92 added breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: company Something is referring to the company module s: needs decision Needs team/maintainer decision labels Aug 18, 2022
…1280)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Shinigami92 <chrissi92@hotmail.de>
src/definitions/company.ts Outdated Show resolved Hide resolved
renovate bot and others added 2 commits August 18, 2022 11:22
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Minozzzi Minozzzi requested a review from ST-DDT August 18, 2022 12:45
ST-DDT
ST-DDT previously approved these changes Aug 19, 2022
src/modules/company/index.ts Outdated Show resolved Hide resolved
Minozzzi and others added 26 commits August 21, 2022 20:41
…mpany.name with parameter

Co-authored-by: Shinigami <chrissi92@hotmail.de>
…mpany.name with parameter

Co-authored-by: Shinigami <chrissi92@hotmail.de>
…mpany.name with parameter

Co-authored-by: Shinigami <chrissi92@hotmail.de>
@Minozzzi
Copy link
Contributor Author

Guys, I've problems with rebase. I'will close this PR and open another

@Minozzzi Minozzzi closed this Aug 22, 2022
@Minozzzi Minozzzi deleted the refactor/company/formats branch August 22, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: company Something is referring to the company module s: needs decision Needs team/maintainer decision
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants