-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add Dutch province abbreviations #2232
feat(locale): add Dutch province abbreviations #2232
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2232 +/- ##
==========================================
- Coverage 99.60% 99.60% -0.01%
==========================================
Files 2639 2640 +1
Lines 245741 245757 +16
Branches 1158 1156 -2
==========================================
+ Hits 244771 244779 +8
- Misses 943 951 +8
Partials 27 27
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I already approve, it would be nice if you could already sort the values alphabetically (a-z). We plan on
enforcing this via the locale generation script in the future. So if you could already do this we could reduce the git diff in the future :)
I intentionally kept them in the same order as state.ts, because I thought the two files were connected in some way. If that is not needed, I can order them alphabetically. |
No, the files aren't connected with each other, so please sort this one alphabetically. |
I sorted them in this pull request and also in #2233. |
@RobinvanderVliet don't worry about merging next into your PR branches, this will be done automatically before the feature is squash merged. You only need to bother if there are conflicts. |
According to: https://en.wikipedia.org/wiki/ISO_3166-2:NL