-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add GB subdivision codes #2233
Merged
ST-DDT
merged 5 commits into
faker-js:next
from
RobinvanderVliet:add-uk-cubdivision-codes
Jul 9, 2023
Merged
feat(locale): add GB subdivision codes #2233
ST-DDT
merged 5 commits into
faker-js:next
from
RobinvanderVliet:add-uk-cubdivision-codes
Jul 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import-brain
added
p: 1-normal
Nothing urgent
c: locale
Permutes locale definitions
labels
Jul 1, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2233 +/- ##
=======================================
Coverage 99.59% 99.60%
=======================================
Files 2640 2641 +1
Lines 245757 245760 +3
Branches 1155 1156 +1
=======================================
+ Hits 244770 244780 +10
+ Misses 960 953 -7
Partials 27 27
|
xDivisionByZerox
previously approved these changes
Jul 1, 2023
xDivisionByZerox
added
c: feature
Request for new feature
s: accepted
Accepted feature / Confirmed bug
m: location
Something is referring to the location module
labels
Jul 1, 2023
ST-DDT
previously approved these changes
Jul 2, 2023
import-brain
previously approved these changes
Jul 2, 2023
RobinvanderVliet
dismissed stale reviews from import-brain, ST-DDT, and xDivisionByZerox
via
July 2, 2023 11:26
f021cce
xDivisionByZerox
approved these changes
Jul 2, 2023
import-brain
approved these changes
Jul 3, 2023
matthewmayer
approved these changes
Jul 4, 2023
ST-DDT
changed the title
feat(locale): Add UK subdivision codes
feat(locale): Add GB subdivision codes
Jul 9, 2023
ST-DDT
approved these changes
Jul 9, 2023
ST-DDT
changed the title
feat(locale): Add GB subdivision codes
feat(locale): add GB subdivision codes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: feature
Request for new feature
c: locale
Permutes locale definitions
m: location
Something is referring to the location module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to: https://en.wikipedia.org/wiki/ISO_3166-2:GB#Countries_and_province