chore(deps): update typescript-eslint to v6 (major) #2259

renovate · 2023-07-17T00:27:18Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@typescript-eslint/eslint-plugin	`~5.62.0` -> `~6.1.0`
@typescript-eslint/parser	`~5.62.0` -> `~6.1.0`

Release Notes

typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)

`v6.1.0`

Compare Source

Bug Fixes

eslint-plugin: [comma-dangle] fixed crash from undefined predicate.ignore (#7223) (d368164)
eslint-plugin: [no-floating-promises] false negative calling .then with second argument undefined (#6881) (606a52c), closes #6850
eslint-plugin: [no-floating-promises] finally should be transparent to unhandled promises (#7092) (2a4421c)
eslint-plugin: [no-unnecessary-type-constraint] correctly fix in cts/mts files (#6795) (1404796)
eslint-plugin: [no-unused-vars] check if any variable definition is exported (#6873) (587ac30), closes #6188
eslint-plugin: fix schemas across several rules and add schema tests (#6947) (dd31bed)
eslint-plugin: include the rules types in the package (#7215) (a3da11d)

Features

typescript-estree: add EXPERIMENTAL_useProjectService option to use TypeScript project service (#6754) (6d3d162)

You can read about our versioning strategy and releases on our website.

`v6.0.0`

Compare Source

Bug Fixes

bumped ts-api-utils to 0.0.39 (#6497) (217c710)
correct handling of additionalProperties in object schemas (#6939) (489c7a5)
correct lint error after merge (277fdb5)
eslint-plugin: [explicit-module-boundary-types] remove shouldTrackReferences option from schema (#5399) (6d32734)
eslint-plugin: allow parser@^6.0.0 (#6630) (92908bd)
eslint-plugin: remove valid-typeof disable in eslint-recommended (#5381) (b82df5e)
fix illegal decorator check (#6723) (c456f8c)
rename typeParameters to typeArguments where needed (#5384) (08d757b)
replace tsutils with ts-api-tools (#6428) (79327b4)
type-utils: treat intrinsic types as if they are from lib and never match error types (#6869) (ecb57de)
typescript-estree: account for namespace nesting in AST conversion (#6272) (09e3877)
update exports field in package.json files (#6550) (53776c2)

chore

drop support for node v14.17, v17 (#5971) (cc62015)

Features

add new package rule-tester (#6777) (2ce1c1d)
add package.json exports for public packages (#6458) (d676683)
bump minimum supported TS version to 4.2.4 (#5915) (a8e71d5)
bump ts-api-utils to v0.0.21 (#6459) (3915661)
bump ts-api-utils to v0.0.22 (#6472) (b88cd23)
drop support for ESLint v6 (#5972) (bda806d)
drop support for node v12 (#5918) (7e3fe9a)
drop support for node v14 and test against node v20 (#7022) (e6235bf)
eslint-plugin: [prefer-nullish-coalescing]: add support for assignment expressions (#5234) (4bdbe67)
eslint-plugin: [prefer-optional-chain] handle cases where the first operands are unrelated to the rest of the chain and add type info (#6397) (02a37c4)
eslint-plugin: [prefer-readonly-parameter-types] added an optional type allowlist (#4436) (c9427b7)
eslint-plugin: [restrict-plus-operands] change checkCompoundAssignments to skipCompoundAssignments (#7027) (dc801d8)
eslint-plugin: add config that disables type-aware linting (#6470) (3b063cf)
eslint-plugin: apply final v6 changes to configs (#7110) (c13ce0b)
eslint-plugin: deprecate no-type-alias (#6229) (820bdf2)
eslint-plugin: final final config changes for v6 (#7157) (e35c5c1)
eslint-plugin: rework configs: recommended, strict, stylistic; -type-checked (#5251) (5346b5b), closes #5036 #5834 #5882 #5864 #3076 #5834 #5882 #5864 #5889 #5834 #5882 #5864 #5883 #4863 #5381 #5256 #5399
fork json schema types for better compat with ESLint rule validation (#6963) (a4967f2)
improve rule schemas, add test to validate schemas, add tooling to generate schema types (#6899) (acc1a43)
made BaseNode.parent non-optional (#5252) (a4768f3), closes #5036 #5834 #5882 #5864 #3076 #5834 #5882 #5864 #5889 #5834 #5882 #5864 #5883 #4863 #5381 #5256 #5399
remove RuleTester in /utils in favour of the new /rule-tester package (#6816) (c33f497)
remove partial type-information program (#6066) (7fc062a)
typescript-estree: add type checker wrapper APIs to ParserServicesWithTypeInformation (#6404) (62d5755)
typescript-estree: added allowInvalidAST option to not throw on invalid tokens (#6247) (a3b177d)
typescript-estree: check for illegal decorators on function declarations (#6590) (1b39cfd)
typescript-estree: check modifiers on every node (#6615) (62d6230)
typescript-estree: remove optionality from AST boolean properties (#6274) (df131e2)
typescript-estree: throw errors for object methods without function bodies (#6589) (1d78576)
typescript-estree: throw errors when abstract property has initializer (#6613) (dcdbc76)

BREAKING CHANGES

eslint-plugin: Adds an additional class of checks to the rule
drop support for ESLint v6
drops support for node v17
Bumps the minimum supported range and removes handling for old versions
drops support for node v12

You can read about our versioning strategy and releases on our website.

typescript-eslint/typescript-eslint (@typescript-eslint/parser)

`v6.1.0`

Compare Source

Features

typescript-estree: add EXPERIMENTAL_useProjectService option to use TypeScript project service (#6754) (6d3d162)

You can read about our versioning strategy and releases on our website.

`v6.0.0`

Compare Source

Bug Fixes

update exports field in package.json files (#6550) (53776c2)

chore

drop support for node v14.17, v17 (#5971) (cc62015)

Features

add new package rule-tester (#6777) (2ce1c1d)
add package.json exports for public packages (#6458) (d676683)
drop support for ESLint v6 (#5972) (bda806d)
drop support for node v12 (#5918) (7e3fe9a)
drop support for node v14 and test against node v20 (#7022) (e6235bf)
remove partial type-information program (#6066) (7fc062a)
scope-manager: ignore ECMA version (#5889) (f2330f7), closes #5834 #5882 #5864 #5883
typescript-estree: added allowInvalidAST option to not throw on invalid tokens (#6247) (a3b177d)
typescript-estree: allow providing code as a ts.SourceFile (#5892) (af41b7f)
typescript-estree: deprecate createDefaultProgram (#5890) (426d6b6)
typescript-estree: remove optionality from AST boolean properties (#6274) (df131e2)

BREAKING CHANGES

drop support for ESLint v6
drops support for node v17
drops support for node v12

You can read about our versioning strategy and releases on our website.

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

codecov · 2023-07-17T00:44:57Z

Codecov Report

Merging #2259 (c56ab4b) into next (37898ca) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2259      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2638     2638              
  Lines      244685   244685              
  Branches     1082     1083       +1     
==========================================
- Hits       243707   243693      -14     
- Misses        951      965      +14     
  Partials       27       27

see 2 files with indirect coverage changes

xDivisionByZerox · 2023-07-17T22:05:54Z

The failing lint taks seems to be a false positive 🤔 Can someone smarter than me explain why the linter breaks there?

ST-DDT · 2023-07-19T21:40:21Z

Blocked by #2266.

chore: ignore lint warning #2266

ST-DDT · 2023-07-20T20:33:27Z

There are two ways to solve this:

Remove the ignore for the inactive rule

-  // eslint-disable-next-line @typescript-eslint/no-empty-interface
   interface Assertion extends CustomMatchers {}
-  // eslint-disable-next-line @typescript-eslint/no-empty-interface
   interface AsymmetricMatchersContaining extends CustomMatchers {}

Keep the ignore and re-activate the rule

+ '@typescript-eslint/no-empty-interface': 'error',

Any preferences?

Shinigami92 · 2023-07-21T12:33:27Z

Any preferences?

https://typescript-eslint.io/rules/no-empty-interface

Extending "plugin:@typescript-eslint/stylistic" in an ESLint configuration enables this rule.

Please remove the // eslint-disable-next-line @typescript-eslint/no-empty-interface, because the rule is not recommended anymore, but just stylistic

renovate · 2023-07-21T16:20:04Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

renovate bot requested a review from a team as a code owner July 17, 2023 00:27

renovate bot added the c: dependencies Pull requests that adds/updates a dependency label Jul 17, 2023

renovate bot force-pushed the renovate/major-typescript-eslint branch from a114222 to d87f6ca Compare July 17, 2023 08:23

ST-DDT added this to the v8 - None milestone specific tasks milestone Jul 17, 2023

renovate bot force-pushed the renovate/major-typescript-eslint branch 4 times, most recently from a0862fa to c27bff0 Compare July 17, 2023 20:33

renovate bot force-pushed the renovate/major-typescript-eslint branch 3 times, most recently from 4770470 to 5edce7f Compare July 19, 2023 18:48

ST-DDT mentioned this pull request Jul 19, 2023

chore: ignore lint warning #2266

Merged

ST-DDT self-assigned this Jul 19, 2023

renovate bot force-pushed the renovate/major-typescript-eslint branch from 5edce7f to d80e867 Compare July 20, 2023 20:17

renovate bot force-pushed the renovate/major-typescript-eslint branch from d80e867 to ba037de Compare July 20, 2023 22:55

chore(deps): update typescript-eslint to v6

3c51de7

renovate bot force-pushed the renovate/major-typescript-eslint branch from ba037de to 3c51de7 Compare July 21, 2023 07:57

chore: remove obsolete ignore

c56ab4b

ST-DDT approved these changes Jul 21, 2023

View reviewed changes

xDivisionByZerox approved these changes Jul 21, 2023

View reviewed changes

Shinigami92 approved these changes Jul 21, 2023

View reviewed changes

ST-DDT merged commit 9a2f74a into next Jul 21, 2023

ST-DDT deleted the renovate/major-typescript-eslint branch July 21, 2023 22:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update typescript-eslint to v6 (major) #2259

chore(deps): update typescript-eslint to v6 (major) #2259

renovate bot commented Jul 17, 2023 •

edited

Loading

codecov bot commented Jul 17, 2023 •

edited

Loading

xDivisionByZerox commented Jul 17, 2023 •

edited

Loading

ST-DDT commented Jul 19, 2023

ST-DDT commented Jul 20, 2023 •

edited

Loading

Shinigami92 commented Jul 21, 2023

renovate bot commented Jul 21, 2023

chore(deps): update typescript-eslint to v6 (major) #2259

chore(deps): update typescript-eslint to v6 (major) #2259

Conversation

renovate bot commented Jul 17, 2023 • edited Loading

Release Notes

v6.1.0

Bug Fixes

Features

v6.0.0

Bug Fixes

chore

Features

BREAKING CHANGES

v6.1.0

Features

v6.0.0

Bug Fixes

chore

Features

BREAKING CHANGES

Configuration

codecov bot commented Jul 17, 2023 • edited Loading

Codecov Report

xDivisionByZerox commented Jul 17, 2023 • edited Loading

ST-DDT commented Jul 19, 2023

ST-DDT commented Jul 20, 2023 • edited Loading

Shinigami92 commented Jul 21, 2023

renovate bot commented Jul 21, 2023

Edited/Blocked Notification

renovate bot commented Jul 17, 2023 •

edited

Loading

`v6.1.0`

`v6.0.0`

`v6.1.0`

`v6.0.0`

codecov bot commented Jul 17, 2023 •

edited

Loading

xDivisionByZerox commented Jul 17, 2023 •

edited

Loading

ST-DDT commented Jul 20, 2023 •

edited

Loading