Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore lint warning #2266

Merged
merged 1 commit into from
Jul 20, 2023
Merged

chore: ignore lint warning #2266

merged 1 commit into from
Jul 20, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Jul 19, 2023

Fixes the lint warning introduced in #2254.

I didn't set the lint rule to error, because #2259 already does that (and other stuff) implicitly.

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Jul 19, 2023
@ST-DDT ST-DDT requested review from a team July 19, 2023 21:38
@ST-DDT ST-DDT self-assigned this Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #2266 (90d3cad) into next (8530a3e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2266      +/-   ##
==========================================
- Coverage   99.59%   99.59%   -0.01%     
==========================================
  Files        2638     2638              
  Lines      244684   244685       +1     
  Branches     1081     1081              
==========================================
- Hits       243701   243699       -2     
- Misses        956      959       +3     
  Partials       27       27              
Files Changed Coverage Δ
src/internal/bind-this-to-member-functions.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT merged commit db34e37 into next Jul 20, 2023
@ST-DDT ST-DDT deleted the chore/ignore-lint-warning branch July 20, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants