infra(unicorn): no-array-for-each

[ST-DDT]

Ref: #2439

• Check eslint-plugin-unicorn rules to enable/configure/disable #2439

---

Enables the unicorn/no-array-for-each lint rule.

[ST-DDT]

I'm not sure about this one.

[codecov]

Codecov Report

Merging #2461 (32b8329) into next (6cb5aa2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2461      +/-   ##
==========================================
- Coverage   99.58%   99.58%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255529   255518      -11     
  Branches     1106     1104       -2     
==========================================
- Hits       254478   254464      -14     
- Misses       1023     1026       +3     
  Partials       28       28              

Files	Coverage Δ
src/modules/datatype/index.ts	100.00% <100.00%> (ø)
src/modules/system/index.ts	100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

[xDivisionByZerox]

Personally, I prefer for..of loops over Array.prototype.forEach. It make the code more consistent as you can use for..of for all iterables and not only arrays. Additionally, I've read some time ago that they were supposed to be more performant, but according to this StackOverflow comment this is no longer the case. Last argument I can bring for the for..of loop is that you dont leave the this scope. This resolves potential issues with hoisting or this-binding.

[xDivisionByZerox]

Personally, I prefer for..of loops over Array.prototype.forEach. It make the code more consistent as you can use for..of for all iterables and not only arrays. Additionally, I've read some time ago that they were supposed to be more performant, but according to this StackOverflow comment this is no longer the case. Last argument I can bring for the for..of loop is that you dont leave the this scope. This resolves potential issues with hoisting or this-binding.