Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(person): add job titles for fr #2531

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Conversation

matthewmayer
Copy link
Contributor

This uses the new job_title_pattern to add job titles with a logical order for French e.g.

Coordinateur en chef de la tactique
Executif central des facteurs
Stagiaire corporate des marchés

Due to the need to translate “of” in French to de, de la, des, du, etc depending on the number and gender of the noun, this is incorporated into the level definitions.

The fr_BE and fe_CH definitions are deleted so the standard fr ones can fall through.

This uses the new job_title_pattern to add job titles with a logical order for French e.g.

```
Coordinateur en chef de la tactique
Executif central des facteurs
Stagiaire corporate des marchés
```

Due to the need to translate “of” in French to de, de la, des, du, etc depending on the number and gender of the noun, this is incorporated into the level definitions.

The fr_BE and fe_CH definitions are deleted so the standard fr ones can fall through.
@matthewmayer matthewmayer requested a review from a team as a code owner November 8, 2023 00:23
@matthewmayer matthewmayer self-assigned this Nov 8, 2023
@matthewmayer matthewmayer added m: person Something is referring to the person module p: 1-normal Nothing urgent labels Nov 8, 2023
@matthewmayer
Copy link
Contributor Author

@makhtar-sarr if you're available to help review this (i'm not a native French speaker) that would be appreciated!

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2531 (a1f94e2) into next (d53c7ac) will increase coverage by 0.00%.
Report is 1 commits behind head on next.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2531   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2806     2805    -1     
  Lines      250060   250069    +9     
  Branches     1100     1098    -2     
=======================================
+ Hits       248993   249002    +9     
  Misses       1039     1039           
  Partials       28       28           
Files Coverage Δ
src/locales/fr/person/index.ts 100.00% <100.00%> (ø)
src/locales/fr/person/job_title_pattern.ts 100.00% <100.00%> (ø)
src/locales/fr/person/title.ts 100.00% <100.00%> (ø)
src/locales/fr_BE/person/index.ts 100.00% <ø> (ø)
src/locales/fr_CH/person/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@matthewmayer matthewmayer added this to the v8.x milestone Nov 8, 2023
src/locales/fr/person/title.ts Outdated Show resolved Hide resolved
src/locales/fr/person/title.ts Show resolved Hide resolved
src/locales/fr/person/title.ts Show resolved Hide resolved
@ST-DDT ST-DDT requested review from a team November 10, 2023 16:37
@ST-DDT ST-DDT modified the milestones: v8.x, vAnytime Nov 14, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Nov 15, 2023

@matthewmayer Is this ready for merge?

@matthewmayer
Copy link
Contributor Author

Yes

@ST-DDT ST-DDT enabled auto-merge (squash) November 17, 2023 23:44
@ST-DDT ST-DDT merged commit ba28ab6 into faker-js:next Nov 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m: person Something is referring to the person module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants