Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(person): add job titles for fr #2531

Merged
merged 4 commits into from
Nov 17, 2023
Merged

feat(person): add job titles for fr #2531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c9ff57
feat(person): add job titles for fr
matthewmayer Nov 8, 2023
e290574
apply review suggestions
matthewmayer Nov 10, 2023
367f689
Merge branch 'next' into fr_jobs
ST-DDT Nov 13, 2023
a1f94e2
Merge branch 'next' into fr_jobs
ST-DDT Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/locales/fr/person/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import type { PersonDefinition } from '../../..';
import female_first_name from './female_first_name';
import female_prefix from './female_prefix';
import first_name from './first_name';
import job_title_pattern from './job_title_pattern';
import last_name from './last_name';
import last_name_pattern from './last_name_pattern';
import male_first_name from './male_first_name';
Expand All @@ -19,6 +20,7 @@ const person: PersonDefinition = {
female_first_name,
female_prefix,
first_name,
job_title_pattern,
last_name,
last_name_pattern,
male_first_name,
Expand Down
3 changes: 3 additions & 0 deletions src/locales/fr/person/job_title_pattern.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default [
'{{person.jobType}} {{person.jobArea}} {{person.jobDescriptor}}',
];
52 changes: 52 additions & 0 deletions src/locales/fr/person/title.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,56 @@ export default {
'Agent',
'Stagiaire',
],
descriptor: [
ST-DDT marked this conversation as resolved.
Show resolved Hide resolved
'central',
'client',
matthewmayer marked this conversation as resolved.
Show resolved Hide resolved
'direct',
'futur',
'humain',
'international',
'interne',
'mondial',
'national',
'principal',
'régional',
],
level: [
'de configuration',
'de division',
'de groupe',
'de la communication',
'de la création',
'de la marque',
'de la mise en œuvre',
'de la mobilité',
'de la qualité',
'de la réponse',
'de la responsabilité',
'de la sécurité',
'de la tactique',
'de marque',
'de paradigme',
'de programme',
'de recherche',
'des applications',
'des comptes',
'des directives',
'des données',
'des facteurs',
'des fonctionnalités',
'des infrastructures',
'des interactions',
'des marchés',
'des métriques',
'des opérations',
'des solutions',
'du marketing',
'du web',
"de l'assurance",
"de l'identité",
"de l'intégration",
"de l'intranet",
"de l'optimisation",
"de l'utilisabilité",
],
};
2 changes: 0 additions & 2 deletions src/locales/fr_BE/person/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import male_prefix from './male_prefix';
import name_ from './name';
import prefix from './prefix';
import suffix from './suffix';
import title from './title';

const person: PersonDefinition = {
female_first_name,
Expand All @@ -28,7 +27,6 @@ const person: PersonDefinition = {
name: name_,
prefix,
suffix,
title,
};

export default person;
22 changes: 0 additions & 22 deletions src/locales/fr_BE/person/title.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/locales/fr_CH/person/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import male_prefix from './male_prefix';
import name_ from './name';
import prefix from './prefix';
import sex from './sex';
import title from './title';

const person: PersonDefinition = {
female_first_name,
Expand All @@ -26,7 +25,6 @@ const person: PersonDefinition = {
name: name_,
prefix,
sex,
title,
};

export default person;
22 changes: 0 additions & 22 deletions src/locales/fr_CH/person/title.ts
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions test/all-functional.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ const BROKEN_LOCALE_METHODS = {
person: {
prefix: ['az', 'id_ID', 'ru', 'zh_CN', 'zh_TW'],
suffix: ['az', 'it', 'mk', 'pt_PT', 'ro_MD', 'ru'],
jobArea: ['ar', 'fr', 'fr_BE', 'fr_CA', 'fr_CH', 'fr_LU', 'fr_SN'],
jobDescriptor: ['ar', 'fr', 'fr_BE', 'fr_CA', 'fr_CH', 'fr_LU', 'fr_SN'],
jobTitle: ['ar', 'fr', 'fr_BE', 'fr_CA', 'fr_CH', 'fr_LU', 'ur', 'fr_SN'],
jobArea: ['ar'],
jobDescriptor: ['ar'],
jobTitle: ['ar', 'ur'],
jobType: ['ur'],
},
} satisfies {
Expand Down