-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix "browse api" button in light mode #2627
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2627 +/- ##
=======================================
Coverage 99.57% 99.58%
=======================================
Files 2807 2807
Lines 250452 250452
Branches 1154 1155 +1
=======================================
+ Hits 249398 249403 +5
+ Misses 1026 1021 -5
Partials 28 28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "just" fixes the color for the API button in dark mode. Correct? IN that case I would not close #2626 after this is merged.
if it accidentally gets auto-closed, we will reopen it 👍 |
you misunderstood the fix |
Please add a proper description to the PRs so that we don't have to guess what the PRs do. |
@matthewmayer In your screenshots #2632 (comment) the button looks okay 🤔 |
I tested my changes on top of this PR, assuming this PR would get merged first. |
related to #2626