Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix "browse api" button in light mode #2627

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jan 28, 2024

related to #2626

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Jan 28, 2024
@Shinigami92 Shinigami92 added this to the v8.x milestone Jan 28, 2024
@Shinigami92 Shinigami92 self-assigned this Jan 28, 2024
@Shinigami92 Shinigami92 requested a review from a team January 28, 2024 14:28
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 28, 2024 14:28
@Shinigami92 Shinigami92 linked an issue Jan 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5dd0fa) 99.57% compared to head (35a65e3) 99.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2627   +/-   ##
=======================================
  Coverage   99.57%   99.58%           
=======================================
  Files        2807     2807           
  Lines      250452   250452           
  Branches     1154     1155    +1     
=======================================
+ Hits       249398   249403    +5     
+ Misses       1026     1021    -5     
  Partials       28       28           

see 1 file with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This "just" fixes the color for the API button in dark mode. Correct? IN that case I would not close #2626 after this is merged.

@Shinigami92
Copy link
Member Author

This "just" fixes the color for the API button in dark mode. Correct? IN that case I would not close #2626 after this is merged.

if it accidentally gets auto-closed, we will reopen it 👍

@ST-DDT
Copy link
Member

ST-DDT commented Jan 28, 2024

For me this is still blue!? 🤔

grafik
grafik

@Shinigami92
Copy link
Member Author

For me this is still blue!? 🤔

you misunderstood the fix
the potential rebrand will be done in another PR not by me

@ST-DDT
Copy link
Member

ST-DDT commented Jan 28, 2024

What does this PR do than? Because the button has the same color as prod

grafik

@ST-DDT
Copy link
Member

ST-DDT commented Jan 28, 2024

This one?
grafik

@ST-DDT
Copy link
Member

ST-DDT commented Jan 28, 2024

Please add a proper description to the PRs so that we don't have to guess what the PRs do.

@matthewmayer matthewmayer changed the title docs: fix brand btn color docs: fix "browse api" button in light mode Jan 29, 2024
@Shinigami92
Copy link
Member Author

@matthewmayer In your screenshots #2632 (comment) the button looks okay 🤔
But the diff in your PR does not change the related style 👀
Did you made a screenshot with this fix? Or did it magically work in our PR?!

@matthewmayer
Copy link
Contributor

matthewmayer commented Jan 29, 2024

I tested my changes on top of this PR, assuming this PR would get merged first.

@ST-DDT ST-DDT enabled auto-merge (squash) January 29, 2024 23:37
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title and buttons on homepage have gone blue?
4 participants