-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: override default vitepress brand colors #2632
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2632 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 2807 2807
Lines 250489 250489
Branches 1154 1152 -2
==========================================
- Hits 249430 249420 -10
- Misses 1031 1041 +10
Partials 28 28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe decide first in the meeting if you prefer red green or blue in general, and then I can tweak the colours to make it look nice everywhere. |
Team Decision
|
fix #2626
Originally I was going to make it green but i think red looks quite nice (took the hue from the Faker logo, the saturation and lightness values are from the default Vitepress theme).
()