-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locale): lowercase Mexican color names #3200
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3200 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2805 2805
Lines 217115 217115
Branches 977 976 -1
==========================================
- Hits 217049 217036 -13
- Misses 66 79 +13
|
I'd be happier if we can get some actual Spanish speakers to review. Maybe we can ping some users who contributed to Spanish locale in the past? |
@rasputino I have seen you have contributed some other Spanish translations as well. |
Sure! I'll take a look at it this weekend.
|
Awesome ❤️ |
I'm sorry, but I believe the names are not correct; we shouldn't rely so much on ChatGPT. There are colors like "almendra" ("almond") that simply aren't used or are too "fanciful" to be considered a color. Also, in Mexico, although there are very few differences and it would be perfectly understood, there are colors that are commonly referred to differently. For example, the color "naranja" (orange) in Mexico would be called "anaranjado." Therefore, IMO, it's not correct to delete the file of colors in Mexican Spanish. I'm making this proposal to improve and expand the colors in Spanish from Spain (Castilian). For the Mexican version, it should be reviewed by a native from there. |
@rasputino Would you like to create a PR or should I merge your commit into this one? |
What do you prefer? |
Due to maintainer availability and review rules, it will likely be merged faster if you create a new PR. |
Created: #3230 |
@rasputino Just for clarification. Is the Mexican color list
|
Don’t remove it. It should be reviewed by a Mexican. I can ask some of my Mexican friends if you'd like me to provide the corrections. |
That would be great. |
7ba5e0b
to
2607877
Compare
@rasputino I updated this PR to switch to lowercase Mexican color names as a basic fix for the reported issue. |
Fixes #2841
According to chatgpt Spanish color names are spelled using lowercase.
So this PR fixes the Mexican color names.