Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): improve Spanish color names #3230

Merged
merged 5 commits into from
Nov 2, 2024
Merged

Conversation

rasputino
Copy link
Contributor

According to issue #2841 I propose new list for Spanish colors.

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 50c5408
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6726a63e4f15ed0008fc3001
😎 Deploy Preview https://deploy-preview-3230.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (1da9290) to head (50c5408).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3230   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2805     2805           
  Lines      217070   217098   +28     
  Branches      966      972    +6     
=======================================
+ Hits       216987   217034   +47     
+ Misses         83       64   -19     
Files with missing lines Coverage Δ
src/locales/es/color/human.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@rasputino rasputino marked this pull request as ready for review October 27, 2024 20:37
@rasputino rasputino requested a review from a team as a code owner October 27, 2024 20:37
@ST-DDT ST-DDT changed the title refactor: Spanish color names refactor(locale): improve Spanish color names Oct 27, 2024
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: color Something is referring to the color module labels Oct 27, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 27, 2024
@ST-DDT ST-DDT requested review from a team October 27, 2024 21:31
@ST-DDT
Copy link
Member

ST-DDT commented Oct 27, 2024

Thanks for your contribution ❤️

@ST-DDT ST-DDT enabled auto-merge (squash) November 2, 2024 22:20
@ST-DDT ST-DDT merged commit 99d81be into faker-js:next Nov 2, 2024
23 checks passed
@ST-DDT
Copy link
Member

ST-DDT commented Nov 2, 2024

Your changes will be included in Faker v9.2 which will be released soon (days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: color Something is referring to the color module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants