Sanitize email when name has special characters #2026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1974
Description:
This pull request fixes a small edge case when faking an email with a
name
param with special characters. Lets say,Faker::Internet.email(name: 'martín')
, should not resolve tomartín@example.com
as it is not a valid email.With that in mind, the fix replaces the forbidden character with a
#
. That decision was made basically trying to keep the number of characters in thename
params.I'm open to any suggestions not only regarding the replacement character (
#
) but also the way this pr is written. Also, willing to add more tests if needed