Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(falco): add missing privileges for the apps Kubernetes API group #30

Merged
merged 1 commit into from
Jun 12, 2020
Merged

fix(falco): add missing privileges for the apps Kubernetes API group #30

merged 1 commit into from
Jun 12, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Jun 12, 2020 •
edited
Loading

Porting this fix to the chart.

/kind bug
/cc @fntlnz

@poiana poiana added the lgtm label Jun 12, 2020
@leogr leogr mentioned this pull request Jun 12, 2020
Merged
@poiana poiana added the lgtm label Jun 12, 2020
@poiana poiana requested review from bencer and nestorsalceda June 12, 2020 13:06
@poiana poiana added the lgtm label Jun 12, 2020
@poiana poiana added the lgtm label Jun 12, 2020
@poiana
Copy link
Contributor

poiana commented Jun 12, 2020

@JPLachance: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jun 12, 2020

LGTM label has been added.

Git tree hash: c1f43555414d6c200436ac32f01a9dad24857a67

@poiana
Copy link
Contributor

poiana commented Jun 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, JPLachance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana added the lgtm label Jun 12, 2020
@poiana
Copy link
Contributor

poiana commented Jun 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, JPLachance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 3c6d830 into master Jun 12, 2020
@poiana poiana deleted the fix/apps-k8s-api-group branch June 12, 2020 13:30
@leogr leogr mentioned this pull request Jun 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JPLachance JPLachance JPLachance approved these changes

@fntlnz fntlnz fntlnz approved these changes

@bencer bencer Awaiting requested review from bencer

@nestorsalceda nestorsalceda Awaiting requested review from nestorsalceda

Assignees

@fntlnz fntlnz

Labels
approved dco-signoff: yes kind/bug Something isn't working lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leogr @poiana @fntlnz @JPLachance