Add missing privileges for the apps Kubernetes API group #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es API group Fixes falcosecurity#1064 Signed-off-by: Jean-Philippe Lachance <jplachance@coveo.com>
leodido
approved these changes
Apr 16, 2020
|
LGTM label has been added. Git tree hash: b2f1e5075ffca3df2396f17761814bb9b48c789d
|
|
/milestone 0.22.0 |
fntlnz
approved these changes
Apr 16, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hello @leodido, This issue is also present in the Falco Helm chart. Who maintains that Helm chart? Regards, |
Hey @JPLachance here 👇 the PR to fix the helm chart too Thank you! |
|
Thanks @leogr for approaching this, I had lost track of the JP’s comment
On Fri, 12 Jun 2020 at 15:06, Leonardo Grasso ***@***.***> wrote:
Hello @leodido <https://github.com/leodido>,
This issue is also present in the Falco Helm chart
<https://github.com/helm/charts/blob/master/stable/falco/templates/clusterrole.yaml>.
Who maintains that Helm chart?
Regards,
JP
Hey @JPLachance <https://github.com/JPLachance>
here 👇 the PR to fix the helm chart too
falcosecurity/charts#30 <falcosecurity/charts#30>
Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1136 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA5J44R3ANYLIJ4HNWGWP3RWIR5NANCNFSM4MEHULDA>
.
--
L.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area integrations
What this PR does / why we need it:
In falco/integrations/k8s-using-daemonset/k8s-with-rbac/falco-account.yaml, we create a ClusterRole for the Falco ServiceAccount. I reviewed our kube audit logs and saw that Falco was getting an access denied on:
watch/apis/apps/v1/watch/deployments?pretty=falsewatch/apis/apps/v1/watch/replicasets?pretty=falsewatch/apis/apps/v1/watch/daemonsets?pretty=falseFalco tries those call over and over again which floods audit logs and I'm quite sure Falco is not working as expected without that privilege.
This PR adds the missing privileges and we stop seeing errors in Kubernetes audit logs. We also expect Falco to work a little bit better with those privileges.
Which issue(s) this PR fixes:
Fixes #1064
Does this PR introduce a user-facing change?: