Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create env variable to add options when loading the driver #1896

Closed
mathildeHermet opened this issue Feb 11, 2022 · 7 comments · Fixed by #1901
Closed

Create env variable to add options when loading the driver #1896

mathildeHermet opened this issue Feb 11, 2022 · 7 comments · Fixed by #1901

Comments

@mathildeHermet
Copy link

mathildeHermet commented Feb 11, 2022

Motivation

I have a usecase of Falco where I have a workflow that compiles Falco kernel module and upload it in Artifactory.
When I download it, I have to pass credentials in the header of the request so I need to add options in the curl command in the falco-driver-loader script.

Feature

I would like an environment variable to pass options to the curl command that download Falco kernel module

Alternatives

Add an environment variable like FALCO_DRIVER_CURL_CUSTOM_OPTIONS because FALCO_DRIVER_CURL_OPTIONS already exists

Additional context

@andreabonanno
Copy link
Contributor

Thanks for the idea!
I provided a possible solution enabling curl option override.

@poiana
Copy link
Contributor

poiana commented May 16, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Jun 15, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Jul 15, 2022

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana
Copy link
Contributor

poiana commented Jul 15, 2022

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana poiana closed this as completed Jul 15, 2022
@leogr
Copy link
Member

leogr commented Dec 14, 2022

/reopen

@poiana poiana reopened this Dec 14, 2022
@poiana
Copy link
Contributor

poiana commented Dec 14, 2022

@leogr: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants