Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(script): makes user able to pass custom option to driver-loade… #1901

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

andreabonanno
Copy link
Contributor

@andreabonanno andreabonanno commented Feb 15, 2022

…r curl command

Signed-off-by: Andrea Bonanno andrea@bonanno.cloud

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

What this PR does / why we need it:

Makes possible for the user to pass additional custom options to the curl command invoked by falco-driver-loader, appending them to the ones usually used.

Which issue(s) this PR fixes:

Fixes #1896

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@tspearconquest
Copy link
Contributor

As a user with security concerns in mind, I would like to see that this does not allow passing arbitrary curl options, and instead would prefer if the environment variable was targeted toward the specific use case you have in mind.

@poiana
Copy link
Contributor

poiana commented Mar 11, 2022

@jasondellaluce: The provided milestone is not valid for this repository. Milestones in this repository: [0.31.1, 0.32.0, 1.0.0]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 0.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jasondellaluce
Copy link
Contributor

/milestone 0.32.0

@poiana poiana added this to the 0.32.0 milestone Mar 11, 2022
@leogr
Copy link
Member

leogr commented May 25, 2022

/milestone 0.33.0

@poiana poiana modified the milestones: 0.32.0, 0.33.0 May 25, 2022
@leogr
Copy link
Member

leogr commented Sep 2, 2022

/milestone 0.34.0

@poiana poiana modified the milestones: 0.33.0, 0.34.0 Sep 2, 2022
@poiana
Copy link
Contributor

poiana commented Dec 2, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@tspearconquest
Copy link
Contributor

Hi @leogr will there be a release before this becomes rotten?

@leogr
Copy link
Member

leogr commented Dec 14, 2022

Hi @leogr will there be a release before this becomes rotten?

I apologize I had lost track of this.
I believe we can merge it, but perhaps we should fix the env vat naming.

cc @jasondellaluce

/remove-lifecycle stale

andreabonanno and others added 2 commits December 15, 2022 15:29
…river-loader curl command

Signed-off-by: Andrea Bonanno <andrea@bonanno.cloud>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
@leogr leogr dismissed a stale review via 498e9dc December 15, 2022 14:35
@leogr leogr force-pushed the driver-loader_custom_curl branch from 0480212 to 498e9dc Compare December 15, 2022 14:35
@poiana
Copy link
Contributor

poiana commented Dec 15, 2022

LGTM label has been added.

Git tree hash: b212278244a71b42c6ce0ab8d081943f8f5f121f

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreabonanno, Andreagit97, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create env variable to add options when loading the driver
6 participants