-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(script): makes user able to pass custom option to driver-loade… #1901
update(script): makes user able to pass custom option to driver-loade… #1901
Conversation
98a889f
to
0480212
Compare
As a user with security concerns in mind, I would like to see that this does not allow passing arbitrary curl options, and instead would prefer if the environment variable was targeted toward the specific use case you have in mind. |
@jasondellaluce: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone 0.32.0 |
/milestone 0.33.0 |
/milestone 0.34.0 |
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
Hi @leogr will there be a release before this becomes rotten? |
I apologize I had lost track of this. /remove-lifecycle stale |
…river-loader curl command Signed-off-by: Andrea Bonanno <andrea@bonanno.cloud>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
0480212
to
498e9dc
Compare
LGTM label has been added. Git tree hash: b212278244a71b42c6ce0ab8d081943f8f5f121f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreabonanno, Andreagit97, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…r curl command
Signed-off-by: Andrea Bonanno andrea@bonanno.cloud
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
What this PR does / why we need it:
Makes possible for the user to pass additional custom options to the
curl
command invoked byfalco-driver-loader
, appending them to the ones usually used.Which issue(s) this PR fixes:
Fixes #1896
Special notes for your reviewer:
Does this PR introduce a user-facing change?: