Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a coding style convention and enforce it #688

Closed
leodido opened this issue Jun 25, 2019 · 14 comments
Closed

Setup a coding style convention and enforce it #688

leodido opened this issue Jun 25, 2019 · 14 comments

Comments

@leodido
Copy link
Member

leodido commented Jun 25, 2019

What would you like to be added:

  • A coding convention.
  • A check (with the relative GitHub status check) during PR to verify if the author respected it or not.

Why is this needed:

It'is good practice to have a code base with one unified coding style for readability and maintainability purposes.

@leodido
Copy link
Member Author

leodido commented Jun 25, 2019

Clearly such issue requires a broader spike about C++ coding conventions in order to decide which one to use (and which modifications to apply, eventually).

@stale
Copy link

stale bot commented Aug 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 24, 2019
@leodido
Copy link
Member Author

leodido commented Aug 26, 2019

We definitely still want to complete this. See also #788.

@stale stale bot removed the wontfix label Aug 26, 2019
@stale
Copy link

stale bot commented Oct 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 25, 2019
@leodido
Copy link
Member Author

leodido commented Oct 25, 2019

No way you close this stalebot!

@stale stale bot removed the wontfix label Oct 25, 2019
@stale
Copy link

stale bot commented Dec 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 24, 2019
@leodido
Copy link
Member Author

leodido commented Dec 24, 2019 via email

@stale stale bot removed the wontfix label Dec 24, 2019
@stale
Copy link

stale bot commented Feb 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 22, 2020
@stale stale bot closed this as completed Feb 29, 2020
@leodido leodido reopened this Oct 13, 2020
@stale stale bot removed the wontfix label Oct 13, 2020
@leodido
Copy link
Member Author

leodido commented Oct 13, 2020

/help

@poiana
Copy link
Contributor

poiana commented Oct 13, 2020

@leodido:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@poiana
Copy link
Contributor

poiana commented Jan 11, 2021

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link
Contributor

poiana commented Feb 11, 2021

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link
Contributor

poiana commented Mar 13, 2021

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this as completed Mar 13, 2021
@poiana
Copy link
Contributor

poiana commented Mar 13, 2021

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants