Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported dockerfiles and update docs #1124

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Mar 30, 2020

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area examples

/area rules

/area integrations

/area tests

/area proposals

What this PR does / why we need it:

This PR clean ups unsupported dockerfiles and update the related README as discussed here.

Which issue(s) this PR fixes:

Fixes #1019

Special notes for your reviewer:
Note that I have not renamed the event generator, because of #1089 is still in progress.

Does this PR introduce a user-facing change?:

update(docker): remove RHEL, kernel/linuxkit, and kernel/probeloader images

leogr added 3 commits March 30, 2020 15:51
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

Thanks for bringing my markdown table here, too 😆

@poiana
Copy link
Contributor

poiana commented Mar 30, 2020

LGTM label has been added.

Git tree hash: bde450b2deeecc054246d271748bbb4a3f0d8885

Copy link
Contributor

@fntlnz fntlnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! Thanks a lot @leogr

@poiana
Copy link
Contributor

poiana commented Apr 1, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fntlnz, leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 35691b0 into falcosecurity:master Apr 1, 2020
@leodido leodido added this to the 0.22.0 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and Document Dockerfiles
4 participants