-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported dockerfiles and update docs #1124
Conversation
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally!
Thanks for bringing my markdown table here, too 😆
LGTM label has been added. Git tree hash: bde450b2deeecc054246d271748bbb4a3f0d8885
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this! Thanks a lot @leogr
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fntlnz, leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
What this PR does / why we need it:
This PR clean ups unsupported dockerfiles and update the related README as discussed here.
Which issue(s) this PR fixes:
Fixes #1019
Special notes for your reviewer:
Note that I have not renamed the event generator, because of #1089 is still in progress.
Does this PR introduce a user-facing change?: