-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(falco_scripts): Update falco-driver-loader
cleaning phase
#1950
chore(falco_scripts): Update falco-driver-loader
cleaning phase
#1950
Conversation
35d2cee
to
8dddae9
Compare
The Before
After:
Before The last commit I checked: https://github.com/dell/dkms/blob/3abe63b850b4714df34972ae4486f0c0689022f0/dkms#L1470 I addressed this different output with the following line, for more info look directly at the code in this PR: DRIVER_VERSIONS=$(dkms status -m "${KMOD_NAME}" | tr -d "," | tr "/" " " | cut -d' ' -f2) |
/milestone 0.32.0 |
/retest |
7bfc2e3
to
79d947a
Compare
falco-driver-loader
cleaning phasefalco-driver-loader
cleaning phase
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
Signed-off-by: Andrea Terzolo <andrea.terzolo@polito.it>
44636ff
to
931f919
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
/approve
LGTM label has been added. Git tree hash: 147f4a42a917025f83a9e7ce5d0cc231d8f2b385
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andrea Terzolo andrea.terzolo@polito.it
What type of PR is this?
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
This PR slightly modifies the behavior of the
falco-driver-loader
script. Now the cleaning phase enforces the deletion of the kernel module if it is still loaded. If the script is not able to detach the module, it waits until the user removes it manually. The user can do this by following some specific instructions that will be provided in the documentation... This is necessary to avoid incompatibility issues with driver versions, obtaining errors like the following:This happens with Falco 0.31.1 because we introduced a mechanism to detect incompatible driver versions.
This new cleaning phase is called every time we try to load a new kernel module typing
falco-driver-loader
or explicitly calling it withfalco-driver-loader --clean
.Since both
.deb
and.rpm
packages have to perform the same cleaning phase when uninstalled now they call directlyfalco-driver-loader --clean
.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: