Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(scripts): updated falco-driver-loader to properly support talos. #2537

Merged
merged 1 commit into from
May 16, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 9, 2023

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

What this PR does / why we need it:

This PR adds support for talos in falco-driver-loader.
Part of the effort for prebuilt artifacts for talos:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

WIP because i first want to test that the kernelconfigdata we are fetching can correctly build a working driver.

Does this PR introduce a user-facing change?:

new(scripts): properly manage talos prebuilt drivers

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana requested review from Kaizhe and mstemm May 9, 2023 13:18
@FedeDP FedeDP changed the title wip: new(scripts): updated falco-driver-loader to properly support talos. new(scripts): updated falco-driver-loader to properly support talos. May 16, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented May 16, 2023

It's good to go!
/cc @leogr @jasondellaluce

@poiana poiana requested review from jasondellaluce and leogr May 16, 2023 07:17
@FedeDP
Copy link
Contributor Author

FedeDP commented May 16, 2023

/milestone 0.35.0

@poiana poiana added this to the 0.35.0 milestone May 16, 2023
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented May 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 577bcca into master May 16, 2023
@poiana poiana deleted the new/talos branch May 16, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants