Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(config): added talos build-drivers jobs. #1129

Merged
merged 2 commits into from
May 20, 2023
Merged

new(config): added talos build-drivers jobs. #1129

merged 2 commits into from
May 20, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented May 9, 2023

WIP because i first want to test that the kernelconfigdata we are fetching can correctly build a working driver.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 9, 2023

Like for #1099 we will eventually need a new driverkit tag too.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 15, 2023

Rebased on top of master.

@FedeDP FedeDP changed the title wip: new(config): added talos build-drivers jobs. new(config): added talos build-drivers jobs. May 16, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented May 16, 2023

/hold until driverkit gets released and bumped on test-infra.

@FedeDP
Copy link
Contributor Author

FedeDP commented May 19, 2023

The PR to bump driverkit is opened: #1160
/unhold

@maxgio92
Copy link
Member

/cc

@poiana poiana requested a review from maxgio92 May 19, 2023 15:46
Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

maxgio92
maxgio92 previously approved these changes May 19, 2023
Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

FedeDP added 2 commits May 19, 2023 19:29
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented May 19, 2023

Rebased on top of master and added tolerations! @maxgio92

Copy link
Member

@maxgio92 maxgio92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana merged commit 13f7aa5 into master May 20, 2023
@poiana
Copy link
Contributor

poiana commented May 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, maxgio92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana deleted the new/talos branch May 20, 2023 09:00
@poiana
Copy link
Contributor

poiana commented May 20, 2023

@FedeDP: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key build-new-talos.yaml using file config/jobs/build-drivers/build-new-talos.yaml

In response to this:

WIP because i first want to test that the kernelconfigdata we are fetching can correctly build a working driver.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants