-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(ci): enable actuated.dev #2945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
😍
LGTM label has been added. Git tree hash: 788af6468fbb7690d6a50619b272b5cc17c1e69f
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@LucaGuerra our metering action will give you an idea whether you're under/over provisioned on vCPU / RAM https://gist.github.com/alexellis/1f33e581c75e11e161fe613c46180771 |
Signed-off-by: Luca Guerra <luca@guerra.sh>
37fb0e2
to
1044909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If everything works fine, i would try to enable back falco-driver-loader tests on arm too (L80).
I think we should also update |
@alexellis i tried adding
(See https://github.com/falcosecurity/libs/actions/runs/7113326475/job/19365044980?pr=1555) |
GitHub.com is signed by a valid authority.. I'm not sure how you got that error. Is there anything else going on inside your environment, like self-signed CAs or intercepting proxies? Perhaps try it again. Edit: It seems like you're using the "containers" feature, so perhaps the base image you picked doesn't have CA certs installed to allow packages to be installed? I'm also not sure if telemetry works or makes sense within the context of the "containers" feature. |
Yeah i don't know either. I think we will need to add metrics to an ubuntu-22.04 job that does not use containers. |
Signed-off-by: Luca Guerra <luca@guerra.sh>
e3fdad7
to
2168dcd
Compare
@FedeDP enabled and tested, seems like they're working ;) |
test-dev-packages-arm64: | ||
needs: [fetch-version, build-dev-packages] | ||
uses: ./.github/workflows/reusable_test_packages.yaml | ||
strategy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the strategy here and remove static:
below, since we don't yet support static
builds on arm64 (but i will rebase #2532 and fix it once this is in!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After all It is not an issue at all to leave them here anyway!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I will add static build for arm64 and then we'll need to update required checks in test infra!
I think we can also try to run driver tests on arm64 too.
LGTM label has been added. Git tree hash: 864c9b6491a7112c96f1d8689e9438f57c8f26b0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
on behalf of Luca since I know he is out.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Add the https://actuated.dev service to execute ARM64 GitHub Actions instead of our self hosted runner. Following the instructions on: https://actuated.dev/blog/arm-ci-cncf-ampere
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: