Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(ci): enable actuated.dev #2945

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

LucaGuerra
Copy link
Contributor

@LucaGuerra LucaGuerra commented Dec 5, 2023

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

What this PR does / why we need it:

Add the https://actuated.dev service to execute ARM64 GitHub Actions instead of our self hosted runner. Following the instructions on: https://actuated.dev/blog/arm-ci-cncf-ampere

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Andreagit97
Andreagit97 previously approved these changes Dec 5, 2023
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
😍

@poiana
Copy link
Contributor

poiana commented Dec 5, 2023

LGTM label has been added.

Git tree hash: 788af6468fbb7690d6a50619b272b5cc17c1e69f

@Andreagit97 Andreagit97 added this to the 0.37.0 milestone Dec 5, 2023
FedeDP
FedeDP previously approved these changes Dec 6, 2023
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@alexellis
Copy link

@LucaGuerra our metering action will give you an idea whether you're under/over provisioned on vCPU / RAM

https://gist.github.com/alexellis/1f33e581c75e11e161fe613c46180771

Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra LucaGuerra dismissed stale reviews from FedeDP and Andreagit97 via 1044909 December 6, 2023 10:15
@poiana poiana removed the lgtm label Dec 6, 2023
@poiana poiana requested review from Andreagit97 and FedeDP December 6, 2023 10:15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everything works fine, i would try to enable back falco-driver-loader tests on arm too (L80).

@FedeDP
Copy link
Contributor

FedeDP commented Dec 6, 2023

I think we should also update ci.yml file to test on arm64 too now: https://github.com/falcosecurity/falco/blob/master/.github/workflows/ci.yml#L19, just like we do for release jobs.

@FedeDP
Copy link
Contributor

FedeDP commented Dec 6, 2023

@alexellis i tried adding vmmeter to my libs PR: falcosecurity/libs#1555
I received:

/usr/bin/docker exec  9bd7029962069069a92f9088e934f9d8057624233dad67e63b8d871618fedfeb sh -c "cat /etc/*release | grep ^ID"
Installing arkade into tool cache
Arch: x64
Download URL: https://github.com/alexellis/arkade/releases/download/0.10.17/arkade
Downloaded arkade to: /__w/_temp/89e60708-1181-48c7-b184-0fb4f538bb59
Moving arkade from /__w/_temp/89e60708-1181-48c7-b184-0fb4f538bb59 to /__w/_temp/arkade
Final path: /__w/_temp/arkade
Setting arkade's folder to: /github/home/.arkade/bin
Installing: crane with latest
/__w/_temp/arkade get --progress=false --quiet=true crane
Error: Head "https://github.com/google/go-containerregistry/releases/latest": tls: failed to verify certificate: x509: certificate signed by unknown authority

(See https://github.com/falcosecurity/libs/actions/runs/7113326475/job/19365044980?pr=1555)

@poiana poiana added size/M and removed size/S labels Dec 6, 2023
@alexellis
Copy link

alexellis commented Dec 6, 2023

GitHub.com is signed by a valid authority.. I'm not sure how you got that error. Is there anything else going on inside your environment, like self-signed CAs or intercepting proxies? Perhaps try it again.

#2945 (comment)

Edit: It seems like you're using the "containers" feature, so perhaps the base image you picked doesn't have CA certs installed to allow packages to be installed?

I'm also not sure if telemetry works or makes sense within the context of the "containers" feature.

@FedeDP
Copy link
Contributor

FedeDP commented Dec 6, 2023

I'm also not sure if telemetry works or makes sense within the context of the "containers" feature.

Yeah i don't know either. I think we will need to add metrics to an ubuntu-22.04 job that does not use containers.

Signed-off-by: Luca Guerra <luca@guerra.sh>
@LucaGuerra
Copy link
Contributor Author

@FedeDP enabled and tested, seems like they're working ;)

test-dev-packages-arm64:
needs: [fetch-version, build-dev-packages]
uses: ./.github/workflows/reusable_test_packages.yaml
strategy:
Copy link
Contributor

@FedeDP FedeDP Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the strategy here and remove static: below, since we don't yet support static builds on arm64 (but i will rebase #2532 and fix it once this is in!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After all It is not an issue at all to leave them here anyway!

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I will add static build for arm64 and then we'll need to update required checks in test infra!
I think we can also try to run driver tests on arm64 too.

@poiana poiana added the lgtm label Dec 7, 2023
@poiana
Copy link
Contributor

poiana commented Dec 7, 2023

LGTM label has been added.

Git tree hash: 864c9b6491a7112c96f1d8689e9438f57c8f26b0

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

on behalf of Luca since I know he is out.

@poiana
Copy link
Contributor

poiana commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,LucaGuerra,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 8cf9b35 into falcosecurity:master Dec 7, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants