new(ci): make use of `actuated.dev` arm64 nodes for arm64 jobs. #1555

FedeDP · 2023-12-06T09:00:52Z

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Moreover, split up drivers_ci from main ci to simplify maintenance.

Which issue(s) this PR fixes:

Fixes #

See #1384

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP · 2023-12-06T09:01:30Z

.circleci/config.yml

-            mkdir -p /tmp/libs/build
-            cd /tmp/libs/build && cmake -DUSE_BUNDLED_DEPS=Off -DBUILD_BPF=Off -DBUILD_DRIVER=Off ..
-            make run-unit-tests -j6
-
  "test-clang-7":


This is the only job left on circleCI.

I don't know if we can remove it though.

let's leave it until we can test it in the kernel testing

FedeDP · 2023-12-06T09:31:33Z

/cc @LucaGuerra @Andreagit97

FedeDP · 2023-12-06T09:38:07Z

We have some required jobs that will need to get updated on test-infra.

FedeDP · 2023-12-06T14:40:02Z

/hold for now

Moreover, split up `drivers_ci` from main `ci` to simplify maintenance. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

…arm64. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

…skipped eventually). Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

FedeDP · 2023-12-13T09:58:41Z

.github/workflows/drivers_ci.yml

+  cancel-in-progress: true
+
+jobs:
+  paths-filter:


We cannot use workflow level paths filter because of https://github.com/orgs/community/discussions/26251.
Otherwise our required status checks won't be properly set to "skipped".

FedeDP · 2023-12-13T09:59:56Z

.github/workflows/drivers_ci.yml

+        arch: [amd64, arm64]
+    steps:
+      - name: Checkout Libs ⤵️
+        if: needs.paths-filter.outputs.driver_changed == 'true' || needs.paths-filter.outputs.libscap_changed == 'true'


We need to skip each step because of https://github.com/orgs/community/discussions/9141.
This avoids having a skipped job whose name is not the resolved matrix name but instead:

CI Build / build-drivers-${{ matrix.arch }} 😄 : (system_deps) (pull_request) Skipped

thus breaking the required status checks once again.

FedeDP · 2023-12-13T10:00:03Z

.github/workflows/drivers_ci.yml

@@ -0,0 +1,188 @@
+name: Drivers CI Build


…/community/discussions/9141. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Andreagit97 · 2023-12-13T11:06:47Z

I would like to have it in 0.14.0 to have the CI synched with master, IMO we can merge it after #1496

FedeDP · 2023-12-13T12:07:35Z

falcosecurity/test-infra#1319 is now merged, and we should be ready to merge this one.

Andreagit97

/approve

Andreagit97 · 2023-12-13T11:01:04Z

.circleci/config.yml

-            mkdir -p /tmp/libs/build
-            cd /tmp/libs/build && cmake -DUSE_BUNDLED_DEPS=Off -DBUILD_BPF=Off -DBUILD_DRIVER=Off ..
-            make run-unit-tests -j6
-
  "test-clang-7":


let's leave it until we can test it in the kernel testing

poiana · 2023-12-13T14:33:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FedeDP · 2023-12-13T14:35:08Z

/unhold

poiana added kind/feature New feature or request do-not-merge/work-in-progress release-note-none dco-signoff: yes area/CI labels Dec 6, 2023

poiana requested review from gnosek and hbrueckner December 6, 2023 09:00

poiana added approved size/XL labels Dec 6, 2023

FedeDP commented Dec 6, 2023

View reviewed changes

FedeDP force-pushed the new/automated_arm64_ci branch 2 times, most recently from 3edf02f to 1e97069 Compare December 6, 2023 09:31

poiana requested review from Andreagit97 and LucaGuerra December 6, 2023 09:31

FedeDP mentioned this pull request Dec 6, 2023

update(ci): enable actuated.dev falcosecurity/falco#2945

Merged

FedeDP changed the title ~~wip: new(ci): make use of automated arm64 nodes for arm64 jobs.~~ new(ci): make use of automated arm64 nodes for arm64 jobs. Dec 6, 2023

poiana removed the do-not-merge/work-in-progress label Dec 6, 2023

FedeDP changed the title ~~new(ci): make use of automated arm64 nodes for arm64 jobs.~~ new(ci): make use of actuated.dev arm64 nodes for arm64 jobs. Dec 6, 2023

FedeDP force-pushed the new/automated_arm64_ci branch from c16a75d to 1e97069 Compare December 6, 2023 11:46

poiana added the do-not-merge/hold label Dec 6, 2023

Andreagit97 added this to the 0.15.0 milestone Dec 11, 2023

FedeDP added 2 commits December 13, 2023 10:15

new(ci): make use of automated arm64 nodes for arm64 jobs.

8a3c5cd

Moreover, split up `drivers_ci` from main `ci` to simplify maintenance. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

chore(ci): consistent naming between ci and drivers_ci for amd64 and …

06b739f

…arm64. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

FedeDP force-pushed the new/automated_arm64_ci branch from 1e97069 to 06b739f Compare December 13, 2023 09:20

FedeDP added 2 commits December 13, 2023 10:23

chore: avoid build-libs-linux- job name breaking change.

c89c4bd

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

chore(ci): make sure required status checks jobs are always run (and …

0076935

…skipped eventually). Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

FedeDP force-pushed the new/automated_arm64_ci branch from 25a3066 to 0076935 Compare December 13, 2023 09:30

chore: drivers_ci new name.

bcd91df

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

FedeDP commented Dec 13, 2023

View reviewed changes

.github/workflows/drivers_ci.yml

@@ -0,0 +1,188 @@

name: Drivers CI Build

Copy link

Contributor Author

FedeDP Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New name.

chore(ci): skip each step to avoid issue like https://github.com/orgs…

2229e1a

…/community/discussions/9141. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

FedeDP force-pushed the new/automated_arm64_ci branch from d67fe6b to 2229e1a Compare December 13, 2023 10:18

Andreagit97 modified the milestones: 0.15.0, 0.14.0 Dec 13, 2023

Andreagit97 approved these changes Dec 13, 2023

View reviewed changes

poiana assigned Andreagit97 Dec 13, 2023

poiana added the lgtm label Dec 13, 2023

LucaGuerra approved these changes Dec 13, 2023

View reviewed changes

poiana assigned LucaGuerra Dec 13, 2023

poiana removed the do-not-merge/hold label Dec 13, 2023

poiana merged commit ea23169 into master Dec 13, 2023

poiana deleted the new/automated_arm64_ci branch December 13, 2023 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new(ci): make use of `actuated.dev` arm64 nodes for arm64 jobs. #1555

new(ci): make use of `actuated.dev` arm64 nodes for arm64 jobs. #1555

FedeDP commented Dec 6, 2023 •

edited

Loading

FedeDP Dec 6, 2023

FedeDP Dec 6, 2023

Andreagit97 Dec 13, 2023

FedeDP commented Dec 6, 2023

FedeDP commented Dec 6, 2023

FedeDP commented Dec 6, 2023

FedeDP Dec 13, 2023

FedeDP Dec 13, 2023

FedeDP Dec 13, 2023

Andreagit97 commented Dec 13, 2023

FedeDP commented Dec 13, 2023

Andreagit97 left a comment

Andreagit97 Dec 13, 2023

poiana commented Dec 13, 2023

FedeDP commented Dec 13, 2023

new(ci): make use of actuated.dev arm64 nodes for arm64 jobs. #1555

new(ci): make use of actuated.dev arm64 nodes for arm64 jobs. #1555

Conversation

FedeDP commented Dec 6, 2023 • edited Loading

FedeDP Dec 6, 2023

Choose a reason for hiding this comment

FedeDP Dec 6, 2023

Choose a reason for hiding this comment

Andreagit97 Dec 13, 2023

Choose a reason for hiding this comment

FedeDP commented Dec 6, 2023

FedeDP commented Dec 6, 2023

FedeDP commented Dec 6, 2023

FedeDP Dec 13, 2023

Choose a reason for hiding this comment

FedeDP Dec 13, 2023

Choose a reason for hiding this comment

FedeDP Dec 13, 2023

Choose a reason for hiding this comment

Andreagit97 commented Dec 13, 2023

FedeDP commented Dec 13, 2023

Andreagit97 left a comment

Choose a reason for hiding this comment

Andreagit97 Dec 13, 2023

Choose a reason for hiding this comment

poiana commented Dec 13, 2023

FedeDP commented Dec 13, 2023

new(ci): make use of `actuated.dev` arm64 nodes for arm64 jobs. #1555

new(ci): make use of `actuated.dev` arm64 nodes for arm64 jobs. #1555

FedeDP commented Dec 6, 2023 •

edited

Loading