new(build): enable ASan and UBSan builds with options and in CI #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
size/S
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
LucaGuerra
force-pushed
the
new/asan-ubsan-ci
branch
4 times, most recently
from
66f6cfa to
e7af7c8
Compare
|
/milestone 0.38.0 |
LucaGuerra
force-pushed
the
new/asan-ubsan-ci
branch
from
e7af7c8 to
2d1739e
Compare
LucaGuerra
force-pushed
the
new/asan-ubsan-ci
branch
from
2d1739e to
1bb20ba
Compare
|
/assign |
LucaGuerra
force-pushed
the
new/asan-ubsan-ci
branch
4 times, most recently
from
672d943 to
af235c0
Compare
LucaGuerra
changed the title
LucaGuerra
force-pushed
the
new/asan-ubsan-ci
branch
4 times, most recently
from
c90b4a7 to
7b3edf5
Compare
|
/hold Let's merge #3151 first, then I'll rebase this and it'll hopefully pass |
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
LucaGuerra
force-pushed
the
new/asan-ubsan-ci
branch
from
7b3edf5 to
21e11c5
Compare
|
/unhold |
FedeDP
reviewed
Mar 29, 2024
Signed-off-by: Luca Guerra <luca@guerra.sh>
LucaGuerra
force-pushed
the
new/asan-ubsan-ci
branch
from
21e11c5 to
2a8bbe1
Compare
|
LGTM label has been added. Git tree hash: 3fdf44aae71afc15c2369d3484f953e5f4516c04
|
incertum
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
/approve
This is great, thanks for implementing it @LucaGuerra!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, incertum, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area CI
What this PR does / why we need it:
This PR adds the following:
USE_ASANandUSE_UBSANoptions to Falco cmakeSupersedes #3104
Which issue(s) this PR fixes:
Fixes #2930
Special notes for your reviewer:
Does this PR introduce a user-facing change?: