Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use vault.centos.org for centos:7 CI build. #3274

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jul 4, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

What this PR does / why we need it:

Enforce the usage of the vault.centos.org mirrors for centos:7 CI. This should fix the CI and let us gain time to design a proper solution to drop centos7.

Also, recently github actions enforced the usage of node20 runners, breaking our actions/checkout step when ran inside centos:7 container (glibc version mismatch); workaround that issue too, by adding the env ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true to the workflow.
See https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(ci): use vault.centos.org for centos:7 CI build.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 4, 2024

/milestone 0.39.0

@poiana poiana added this to the 0.39.0 milestone Jul 4, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 4, 2024

Refs #3270

@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 4, 2024

It seems like arm64 centos-release-scl repo is missing from vault.centos.org :/

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…enforce the usage of node16.

Centos:7 does not support node20 (glibc required mismatch).

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana
Copy link
Contributor

poiana commented Jul 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, leogr, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,LucaGuerra,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 1f2943d into master Jul 8, 2024
33 checks passed
@poiana poiana deleted the fix/centos_7_vault branch July 8, 2024 05:03
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 31, 2024

/milestone 0.38.2

@poiana poiana removed this from the 0.39.0 milestone Jul 31, 2024
@poiana poiana added this to the 0.38.2 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants