Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci,test): fixed centos:7 related CI by using vault.centos.org. #1946

Merged
merged 2 commits into from
Jul 16, 2024
Merged

fix(ci,test): fixed centos:7 related CI by using vault.centos.org. #1946

merged 2 commits into from
Jul 16, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jul 4, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from hbrueckner and mstemm July 4, 2024 07:58
@poiana poiana added the approved label Jul 4, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 4, 2024

/hold for tests.

@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 4, 2024

See falcosecurity/falco#3274 for the tests; it seems like arm64 centos-release-scl repo is missing from vault.centos.org :/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Perf diff from master - unit tests

     4.21%     +3.30%  [.] sinsp_parser::process_event
    11.96%     +3.01%  [.] sinsp_parser::reset
     4.11%     -1.42%  [.] gzfile_read
     4.65%     -1.04%  [.] next
     2.01%     -0.75%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.25%     -0.75%  [.] sinsp_fdtable::find_ref
     3.05%     -0.68%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     0.90%     +0.50%  [.] 0x00000000000e7390
     1.07%     -0.48%  [.] sinsp_threadinfo::~sinsp_threadinfo
     7.18%     +0.47%  [.] sinsp::next

Perf diff from master - scap file

     3.56%     +6.20%  [.] main
     3.45%     +5.15%  [.] sinsp_filter_check::get_field_info
    14.36%     +4.34%  [.] sinsp_filter_check::extract_nocache
     3.56%     +3.98%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     3.62%     +3.97%  [.] sinsp_filter_check_event::extract_single
    14.40%     -3.60%  [.] sinsp_evt_formatter::tostring_withformat
     3.59%     +2.04%  [.] scap_event_decode_params
     7.20%     -1.81%  [.] sinsp::next
     7.18%     -1.79%  [.] sinsp_filter_check::get_transformed_field_info
     7.16%     -1.77%  [.] sinsp_thread_manager::get_thread_ref

Heap diff from master - unit tests

total runtime: 0.04s.
calls to allocation functions: 277 (7914/s)
temporary memory allocations: -7 (-200/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.01s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: -3 (600/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@FedeDP
fix(ci,test): fixed centos:7 related CI by using vault.centos.org.
e5b997f 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana added size/M and removed size/S labels Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Perf diff from master - unit tests

    11.95%     -2.12%  [.] sinsp_parser::reset
     4.11%     -1.25%  [.] gzfile_read
     3.05%     -0.83%  [.] std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release
     3.01%     +0.82%  [.] sinsp_thread_manager::get_thread_ref
     7.18%     +0.75%  [.] sinsp::next
     4.20%     +0.50%  [.] sinsp_parser::process_event
     0.85%     -0.47%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     0.61%     +0.42%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Identity, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >::find
     0.89%     +0.42%  [.] 0x00000000000e7390
     1.25%     -0.41%  [.] sinsp_fdtable::find_ref

Perf diff from master - scap file

    13.79%     +3.51%  [.] sinsp_filter_check::extract_nocache
    10.41%     -1.98%  [.] sinsp_filter_check::tostring
     6.82%     -1.88%  [.] sinsp_thread_manager::find_thread
     3.47%     +1.80%  [.] next
     6.90%     +1.78%  [.] sinsp_filter_check::get_transformed_field_info
     6.92%     +1.78%  [.] sinsp::next
     3.42%     +1.73%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
    13.83%     +1.58%  [.] sinsp_evt_formatter::tostring_withformat
     3.46%     +1.56%  [.] libsinsp::runc::match_one_container_id
     6.94%     -0.32%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node

Heap diff from master - unit tests

total runtime: 0.09s.
calls to allocation functions: 922 (10359/s)
temporary memory allocations: 321 (3606/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: 0.02s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: -4 (-235/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 5, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Jul 5, 2024
FedeDP
FedeDP commented Jul 10, 2024
View reviewed changes
.github/workflows/drivers_ci.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking throughout the file i noticed we use inputs.arch a couple of times but we don't have any inputs here.
I blame copy/paste issues :) will fix it!
/hold

@Andreagit97
Copy link
Member

I think we need this to fix the CI

@FedeDP
chore(ci): cleanup inputs.arch usage in drivers_ci.
87c3a5b 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 16, 2024

Done the inputs.arch cleanup.
/unhold

@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     6.94%     -1.21%  [.] sinsp_thread_manager::find_thread
     3.01%     +1.04%  [.] sinsp_thread_manager::get_thread_ref
     2.26%     -1.00%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     1.91%     -0.81%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     1.15%     -0.62%  [.] scap_event_encode_params_v
     5.19%     -0.58%  [.] next
     0.53%     +0.57%  [.] scap_next
     5.29%     +0.55%  [.] sinsp_evt::get_type
     1.11%     +0.55%  [.] libsinsp::sinsp_suppress::process_event
     1.38%     -0.51%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>

Perf diff from master - scap file

     7.93%     +7.42%  [.] sinsp_evt_formatter::tostring_withformat
     3.87%     +4.93%  [.] sinsp_filter_check::tostring
     3.88%     +4.88%  [.] sinsp_parser::reset
    15.38%     -4.54%  [.] next
     4.00%     +3.28%  [.] sinsp_thread_manager::get_thread_ref
     8.61%     -2.24%  [.] sinsp_thread_manager::find_thread
    11.92%     -1.92%  [.] sinsp_filter_check_event::extract_single
     8.01%     -1.91%  [.] sinsp_filter_check::get_field_info
     3.46%     +1.47%  [.] libsinsp::runc::match_container_id
     8.85%     +0.66%  [.] sinsp_filter_check_thread::extract_single

Heap diff from master - unit tests

total runtime: -0.04s.
calls to allocation functions: -656 (14577/s)
temporary memory allocations: -354 (7866/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

total runtime: -0.05s.
calls to allocation functions: 0 (0/s)
temporary memory allocations: 1 (-20/s)
peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Andreagit97
Andreagit97 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
/approve

@poiana poiana added the lgtm label Jul 16, 2024
@poiana
Copy link
Contributor

poiana commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit f7b1055 into master Jul 16, 2024
42 of 43 checks passed
@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 31, 2024

/milestone 0.17.3

@poiana poiana modified the milestones: 0.18.0, 0.17.3 Jul 31, 2024
@FedeDP FedeDP deleted the fix/centos_7_ci branch July 31, 2024 07:22
@FedeDP FedeDP mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@Andreagit97 Andreagit97

Labels
approved area/CI dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/M
Projects
None yet
Milestone
0.17.3
Development

Successfully merging this pull request may close these issues.
4 participants
@FedeDP @Andreagit97 @poiana @leogr