sync 0.17.x branch #1974

LucaGuerra · 2024-07-23T13:50:18Z

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libsinsp

Does this PR require a change in the driver versions?

/version driver-API-version-patch

What this PR does / why we need it:

Sync 0.17.x release branch with the following changes:

~~Also, increment driver API version because we are patching it (@FedeDP please double check that this is correct).~~ API version does not need to be incremented

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Properly keep a reference on m_sinsp_stats_v2 where needed, instead of fetching it every time. Moreover, improve perf in `sinsp_utils::ts_to_string`: cache `gmt2local` result instead of fetching it every time as it is an heavy operation. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

… return empty value, to be skipped, when requirements are not met. For now, this means that metrics that require `m_sinsp_stats_v2` will be automatically skipped when it is disabled. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

Signed-off-by: Luca Guerra <luca@guerra.sh>

…nd ipnet checks Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>

Signed-off-by: Luca Guerra <luca@guerra.sh>

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>

github-actions · 2024-07-23T14:17:21Z

Please double check driver/API_VERSION file. See versioning.

/hold

FedeDP · 2024-07-23T14:54:08Z

I think we also need #1940 and #1899 for windows related CI jobs.

FedeDP · 2024-07-31T07:16:59Z

/milestone 0.17.3

FedeDP · 2024-07-31T07:19:37Z

Added also #1979 to the 0.17.3 milestone.

FedeDP · 2024-07-31T07:23:25Z

Moved also #1946 to 0.17.3 milestone to fix

Drivers CI Build / build-scap-open-w-extern-bpf-skeleton (pull_request) Failing after 10s

driver/API_VERSION

Build zlib using CMake on Windows instead of nmake. The nmakefile passes "-base:0x5A4C0000" to the linker, which is too small on Arm64 and not really needed or wanted on any platform these days. madler/zlib#325 Signed-off-by: Gerald Combs <gerald@wireshark.org>

Set CMAKE_POLICY_DEFAULT_CMP0091, CMAKE_MSVC_RUNTIME_LIBRARY, and CMAKE_BUILD_TYPE when we configure zlib, similar to our other dependencies. Signed-off-by: Gerald Combs <gerald@wireshark.org>

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

The debug versions of zlib have a "d" in their name, e.g. zlibstaticd.lib. Signed-off-by: Gerald Combs <gerald@wireshark.org>

LucaGuerra · 2024-07-31T09:44:27Z

Thanks @FedeDP , added everything

Include cri.hpp in container.cpp in order to avoid ``` /usr/bin/ld: /usr/lib/aarch64-linux-gnu/libsinsp.so: undefined reference to `libsinsp::cri::cri_interface<libsinsp::cri::cri_api_v1>::get_cri_runtime_type() const' collect2: error: ld returned 1 exit status ``` when building with shared libs on Linux. Signed-off-by: Gerald Combs <gerald@wireshark.org>

Signed-off-by: Luca Guerra <luca@guerra.sh>

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

FedeDP

/approve

poiana · 2024-08-01T08:00:43Z

LGTM label has been added.

Git tree hash: 58713b9e3d6b81e8cfba568ef8bd21623cdce595

Andreagit97

/approve

poiana · 2024-08-01T08:27:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

FedeDP · 2024-08-01T08:29:02Z

/unhold

FedeDP and others added 11 commits July 23, 2024 13:19

chore(userspace/libsinsp): make thiszone thread local.

3c16a13

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

chore(userspace/libsinsp): revert gmt2local changes.

5802fb8

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

fix(libsinsp): fix empty buffer read in transformer

81c598b

Signed-off-by: Luca Guerra <luca@guerra.sh>

fix(userspace/libsinsp): solve issues with negate comparisons on ip a…

2f91bc4

…nd ipnet checks Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>

new(libsinsp): add debug log for corrupted events

71730dd

Signed-off-by: Luca Guerra <luca@guerra.sh>

update(libsinsp): raise error severity

4b89369

Signed-off-by: Luca Guerra <luca@guerra.sh>

cleanup(driver): simplify exe_upper_layer extraction

dba835e

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>

fix(driver): correctly handle upper_dentry in the kmod

640c038

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>

fix(driver/kmod): avoid mixed declarations and code error

e6254d5

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>

poiana added release-note-none kind/bug Something isn't working dco-signoff: yes area/driver-kmod area/driver-bpf area/driver-modern-bpf area/libsinsp size/XXL approved labels Jul 23, 2024

poiana requested review from hbrueckner and jasondellaluce July 23, 2024 13:50

poiana added the do-not-merge/hold label Jul 23, 2024

poiana added this to the 0.17.3 milestone Jul 31, 2024

FedeDP reviewed Jul 31, 2024

View reviewed changes

driver/API_VERSION Outdated Show resolved Hide resolved

geraldcombs and others added 5 commits July 31, 2024 09:43

update(cmake): Make sure we link zlib with the correct Windows CRT

62274fe

Set CMAKE_POLICY_DEFAULT_CMP0091, CMAKE_MSVC_RUNTIME_LIBRARY, and CMAKE_BUILD_TYPE when we configure zlib, similar to our other dependencies. Signed-off-by: Gerald Combs <gerald@wireshark.org>

fix(ci,test): fixed centos:7 related CI by using vault.centos.org.

d1c1b1f

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

chore(ci): cleanup inputs.arch usage in drivers_ci.

9c8dfc1

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>

update(cmake): Use the correct zlib debug library name on Windows

aeaa769

The debug versions of zlib have a "d" in their name, e.g. zlibstaticd.lib. Signed-off-by: Gerald Combs <gerald@wireshark.org>

LucaGuerra force-pushed the update/sync-release-0.17.3 branch from 370da2c to aeaa769 Compare July 31, 2024 09:43

geraldcombs and others added 6 commits August 1, 2024 07:54

fix(libsinsp): add missing include map

1003b0f

Signed-off-by: Luca Guerra <luca@guerra.sh>

fix(sinsp): invalid threads shoudln't be in a pid namespace

f581ec7

Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>

fix(driver/bpf): close maps on cleanup

0bc1794

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

chore(libscap/engine/bpf): reset bpf_map_fds to -1

b8ea9b2

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

chore(engine/bpf): close only used fds

cf1dec3

Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>

FedeDP approved these changes Aug 1, 2024

View reviewed changes

poiana assigned FedeDP Aug 1, 2024

poiana added the lgtm label Aug 1, 2024

Andreagit97 approved these changes Aug 1, 2024

View reviewed changes

poiana assigned Andreagit97 Aug 1, 2024

poiana removed the do-not-merge/hold label Aug 1, 2024

poiana merged commit c0c6639 into falcosecurity:release/0.17.x Aug 1, 2024
49 of 52 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sync 0.17.x branch #1974

sync 0.17.x branch #1974

LucaGuerra commented Jul 23, 2024 •

edited

Loading

github-actions bot commented Jul 23, 2024 •

edited

Loading

FedeDP commented Jul 23, 2024 •

edited

Loading

FedeDP commented Jul 31, 2024

FedeDP commented Jul 31, 2024 •

edited

Loading

FedeDP commented Jul 31, 2024

LucaGuerra commented Jul 31, 2024

FedeDP left a comment

poiana commented Aug 1, 2024

Andreagit97 left a comment

poiana commented Aug 1, 2024

FedeDP commented Aug 1, 2024

sync 0.17.x branch #1974

sync 0.17.x branch #1974

Conversation

LucaGuerra commented Jul 23, 2024 • edited Loading

github-actions bot commented Jul 23, 2024 • edited Loading

FedeDP commented Jul 23, 2024 • edited Loading

FedeDP commented Jul 31, 2024

FedeDP commented Jul 31, 2024 • edited Loading

FedeDP commented Jul 31, 2024

LucaGuerra commented Jul 31, 2024

FedeDP left a comment

Choose a reason for hiding this comment

poiana commented Aug 1, 2024

Andreagit97 left a comment

Choose a reason for hiding this comment

poiana commented Aug 1, 2024

FedeDP commented Aug 1, 2024

LucaGuerra commented Jul 23, 2024 •

edited

Loading

github-actions bot commented Jul 23, 2024 •

edited

Loading

FedeDP commented Jul 23, 2024 •

edited

Loading

FedeDP commented Jul 31, 2024 •

edited

Loading