Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references #918

Closed
wants to merge 13 commits into from
Closed

Remove references #918

wants to merge 13 commits into from

Conversation

leodido
Copy link
Member

@leodido leodido commented Nov 5, 2019

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

NONE

What this PR does / why we need it:

Removes some more unnecessary, legacy references to Falco in Sysdig.

Does this PR introduce a user-facing change?:

update(docker): use HOST_ROOT environment variable rather than SYSDIG_HOST_ROOT
update: EF_DROP_FALCO is now EF_DROP_SIMPLE_CONS
update: puppet module had been renamed from "sysdig-falco" to "falco"

@poiana
Copy link
Contributor

poiana commented Nov 5, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: leodido

If they are not already assigned, you can assign the PR to them by writing /assign @leodido in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana requested review from Kaizhe and mfdii November 5, 2019 17:36
@leodido leodido requested review from fntlnz and ldegio and removed request for Kaizhe and mfdii November 5, 2019 17:36
docker/dev/docker-entrypoint.sh Outdated Show resolved Hide resolved
docker/rhel/docker-entrypoint.sh Outdated Show resolved Hide resolved
docker/stable/docker-entrypoint.sh Outdated Show resolved Hide resolved
scripts/falco-probe-loader Outdated Show resolved Hide resolved
scripts/falco-probe-loader Outdated Show resolved Hide resolved
scripts/falco-probe-loader Outdated Show resolved Hide resolved
scripts/falco-probe-loader Outdated Show resolved Hide resolved
ldegio and others added 13 commits November 8, 2019 14:28
…sdig

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Plus, make them use HOST_ROOT env var, not SYSDIG_HOST_ROOT

Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
Co-authored-by: Lorenzo Fontana <lo@linux.com>
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
@leodido leodido closed this Nov 8, 2019
@leodido
Copy link
Member Author

leodido commented Nov 8, 2019

Closed in favor of #922 for using the convention of testing the branches with the same name together.

@fntlnz fntlnz deleted the remove-refs branch April 7, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants