-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debian package: use systemd if available #989
Conversation
Merging for 0.5.0
Merging for 0.6.0
Merging for 0.7.0
…G_ORC_UNWINDER or CONFIG_STACK_VALIDATION. (falcosecurity#362) sysdig-CLA-1.0-signed-off-by: David Archer <darcher@gmail.com>
falco-CLA-1.0-signed-off-by: Xiang Dai <764524258@qq.com> Signed-off-by: Xiang Dai <764524258@qq.com>
falco-CLA-1.0-signed-off-by: Xiang Dai <764524258@qq.com>
falco-CLA-1.0-signed-off-by: Xiang Dai <764524258@qq.com>1
@juju4: Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integrations/k8s-using-daemonset/README.md
is going to be removed soon by #1157
Please, clean up here too.
/milestone 0.25.0 |
Hey @juju4 Are you still working on this PR? Any updates? |
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
don't see any dev branch currently when editing PR |
I'm pretty sure I did dco but https://github.com/falcosecurity/falco/blob/master/CONTRIBUTING.md is dead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @juju4
Unfortunately, this PR has been opened for a long time, and many things have changed.
I see a lot of merge-commits (that we don't allow to be merged in), and those commits have been not signed off.
So, I believe there are only two options here: rebasing this PR on top of the current master (removing all merge-commits) or creating a new PR.
Btw, recently I noticed that a new similar PR (#1448) was opened, which aims to migrate both RPM and DEB packages. At this point, perhaps it is worth collaborating with the author of the other PR?
PS |
Closing this since #1448 has been merged. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
NONE
What this PR does / why we need it:
#484