cleanup(libsinsp,libscap,libpman): cleanups, fixes for return values, memory management, allocations #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
kind/bug
|
/hold accidentally a commit |
… memory management, allocations Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
LucaGuerra
force-pushed
the
cleanup/edge-case-cleanups
branch
from
fc74890 to
af2946a
Compare
|
/unhold |
|
/milestone 0.10.4 |
22 tasks
FedeDP
reviewed
Feb 16, 2023
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Federico Di Pierro <nierro92@gmail.com> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
LucaGuerra
force-pushed
the
cleanup/edge-case-cleanups
branch
from
d914079 to
b6a1dc3
Compare
therealbobo
reviewed
Feb 16, 2023
therealbobo
reviewed
Feb 16, 2023
… cleaned by the destructor Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Federico Di Pierro <nierro92@gmail.com> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
|
@jasondellaluce thanks for the comments, extra assertions wouldn't hurt, going to accept them |
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
LucaGuerra
force-pushed
the
cleanup/edge-case-cleanups
branch
from
ad066ea to
6e67935
Compare
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
jasondellaluce
approved these changes
Feb 16, 2023
|
LGTM label has been added. Git tree hash: 106db72af068de086b976d937efbe5915d551a90
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area libscap
/area libpman
/area libsinsp
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
This PR cumulates a number of stability fixes to check the following:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: