update branch 0.10.x #893
update branch 0.10.x #893
Conversation
Signed-off-by: Aldo Lacuku <aldo@lacuku.eu>
alacuku
force-pushed
the
kcl/update-brach-0.10.X
branch
2 times, most recently
from
14344b5 to
366d8f6
Compare
userspace/libscap/scap_savefile.c
Outdated
| scap_dumper_t *proclist_dumper = scap_write_proclist_begin(handle); | ||
| if(proclist_dumper == NULL) | ||
| { | ||
| return SCAP_SUCCESS; | ||
| return SCAP_FAILURE; | ||
| } |
There was a problem hiding this comment.
this is a bit different: https://github.com/falcosecurity/libs/pull/888/files#diff-7b4e2af897ce4b8645f4f862762f68425d8394805c45c194255730e99078767dR717
probably needs to be fixed
There was a problem hiding this comment.
That change is not present in the release/0.10.x branch: https://github.com/falcosecurity/libs/blame/release/0.10.x/userspace/libscap/scap_savefile.c#L552
We need to keep it this way. Or we backport the commit that introduced that change into release/0.10.x branch.
There was a problem hiding this comment.
Do we miss the
//
// Exit immediately if the process list is empty
//
if(HASH_COUNT(handle->m_proclist.m_proclist) == 0)
{
return SCAP_SUCCESS;
}
check now? It was present back then in 0.10.x.
There was a problem hiding this comment.
^ yes, I think Aldo already has the correct change and it only needs to be pushed 🚀
… memory management, allocations Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com> Co-authored-by: Federico Di Pierro <nierro92@gmail.com>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Federico Di Pierro <nierro92@gmail.com> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
… cleaned by the destructor Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Federico Di Pierro <nierro92@gmail.com> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Luca Guerra <luca@guerra.sh> Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com> Co-authored-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Melissa Kilby <melissa.kilby.oss@gmail.com>
alacuku
force-pushed
the
kcl/update-brach-0.10.X
branch
from
89f4a06 to
90153ba
Compare
Signed-off-by: Luca Guerra <luca@guerra.sh>
|
LGTM label has been added. Git tree hash: ae4860dcb3f61c85e159546676112df4a6d47b3a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.10.4 |
|
@LucaGuerra: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area libpman
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR cherrypicks the commits introduced by the following PRs:
to
release/0.10.xbranch.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: