Add support for Android chromium-webview [BUG] issue issue #414

family · Jul 30, 2024 · 4b0d0be · 4b0d0be
1 parent 31f6a17
commit 4b0d0be
Showing 1 changed file with 19 additions and 18 deletions.
diff --git a/packages/connectkit/src/components/Common/ConnectorList/index.tsx b/packages/connectkit/src/components/Common/ConnectorList/index.tsx
@@ -34,15 +34,15 @@ const ConnectorList = () => {
     context.options?.hideRecentBadge || lastConnectorId === 'walletConnect' // do not hoist walletconnect to top of list
       ? wallets
       : [
-          // move last used wallet to top of list
-          // using .filter and spread to avoid mutating original array order with .sort
-          ...wallets.filter(
-            (wallet) => lastConnectorId === wallet.connector.id
-          ),
-          ...wallets.filter(
-            (wallet) => lastConnectorId !== wallet.connector.id
-          ),
-        ];
+        // move last used wallet to top of list
+        // using .filter and spread to avoid mutating original array order with .sort
+        ...wallets.filter(
+          (wallet) => lastConnectorId === wallet.connector.id
+        ),
+        ...wallets.filter(
+          (wallet) => lastConnectorId !== wallet.connector.id
+        ),
+      ];
 
   return (
     <ScrollArea mobileDirection={'horizontal'}>
@@ -97,7 +97,7 @@ const ConnectorItem = ({
 
   let deeplink =
     (!wallet.isInstalled && isMobile) ||
-    (wallet.shouldDeeplinkDesktop && !isMobile)
+      (wallet.shouldDeeplinkDesktop && !isMobile)
       ? wallet.getWalletConnectDeeplink?.(uri ?? '')
       : undefined;
 
@@ -114,21 +114,22 @@ const ConnectorItem = ({
       type="button"
       as={deeplink ? 'a' : undefined}
       href={deeplink ? deeplink : undefined}
+      target={deeplink && detectBrowser() === 'chromium-webview' ? '_blank' : undefined}
       disabled={context.route !== routes.CONNECTORS}
       onClick={
         deeplink
           ? undefined
           : () => {
-              if (redirectToMoreWallets) {
-                context.setRoute(routes.MOBILECONNECTORS);
-              } else {
-                if (shouldConnectImmediately) {
-                  connect({ connector: wallet?.connector });
-                }
-                context.setRoute(routes.CONNECT);
-                context.setConnector({ id: wallet.id });
+            if (redirectToMoreWallets) {
+              context.setRoute(routes.MOBILECONNECTORS);
+            } else {
+              if (shouldConnectImmediately) {
+                connect({ connector: wallet?.connector });
               }
+              context.setRoute(routes.CONNECT);
+              context.setConnector({ id: wallet.id });
             }
+          }
       }
     >
       <ConnectorIcon