-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] WalletConnect deeplink breaks in Android WebView "wc:3cc..." should be "wc://3cc..." #414
Comments
I rewrote it from "wc:3cc..." to "wc://3cc..." this still didn't trigger the WebView in Android to open metamask wallet
|
@skhetcho thanks for doing all of this research into this problem! just checking, it sounds like there is no resolve in this PR as the issue still persists even with this change in place? |
I also noticed that I didn't add a fix for wallets inside the "Other" menu |
found the fix! it shouldn't be browserDetect() === 'chromium-webview`, this condition should be isAndroid() ? then the target should be '_blank' pr is coming your way. I tested this on multiple android devices |
Hey @skhetcho, we've been considering migrating from RainbowKit because of this and other problems. We currently have a Telegram Web app with ~100k users. Let me know if we can help you solve/test this issue. |
why are they closing the issue if they didn't find the solution ,still having the same issue |
Describe the bug
Deep linking to external wallets (like WalletConnect wc:3cc.... urls) does not seem to work on Android when loaded inside an app. The app crashes with ERR_UNKOWN_URL_SCHEME
To reproduce
A way to produce opening a ConnectKit inside a webview in an android app could be done by creating a Telegram Mini App which creates a webview instance of the webapp inside the Android App.
1- Create a demo webapp using the
Get Started
guide.2- Host an https instance of the webapp, (you could use nextjs with vercel)
3- Create a mini app on telegram and supply it with your https url to your webapp
4- Launch the mini app and press on connect wallet.
5- Select Metamask, and it will break.
Expected behavior
It should trigger "wc://3cc..." and not "wc:3cc..." - It seems this is only necessary for Android as the wallet connection works seamlessly on the browser, IOS, and desktop.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment details
Android WebView (irrespective of the android version)
Additional context
none
The text was updated successfully, but these errors were encountered: