Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds github action on pull requests and pushes to master, fixes MW-247 #56

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Adds github action on pull requests and pushes to master, fixes MW-247 #56

merged 1 commit into from
Sep 29, 2021

Conversation

GrayedFox
Copy link
Contributor

@GrayedFox GrayedFox commented Sep 22, 2021 •
edited
Loading

This PR

  • adds a table of contents to the readme file
  • adds a testing section that explains running tests to the readme file
  • adds a github actions workflow that should trigger on: pushes to master, all pull requests
  • fixes a compile error with FMAPI.swift file
  • splits existing tests into three dedicated test cases: location, geometric, and filter tests
  • skips the testBlurFilter tests which relies on Metal

There is a problem with using the latest OS tag that should be fixed by November 3rd: actions/runner-images#4060

@GrayedFox GrayedFox self-assigned this Sep 22, 2021
@GrayedFox GrayedFox force-pushed the feature/mw-247-add-github-action-to-run-tests-on-sdk branch from 9a7f074 to 7cfd337 Compare September 22, 2021 14:50
@GrayedFox

This comment has been minimized.

Sign in to view
@GrayedFox GrayedFox force-pushed the feature/mw-247-add-github-action-to-run-tests-on-sdk branch from 7cfd337 to b3d2e99 Compare September 23, 2021 08:30
@GrayedFox GrayedFox changed the title Feature/mw 247 add GitHub action to run tests on sdk Adds github action on pull requests and pushes to master, fixes MW247 Sep 23, 2021
@GrayedFox GrayedFox changed the title Adds github action on pull requests and pushes to master, fixes MW247 Adds github action on pull requests and pushes to master, fixes MW-247 Sep 23, 2021
@GrayedFox GrayedFox marked this pull request as draft September 23, 2021 09:18
@GrayedFox GrayedFox force-pushed the feature/mw-247-add-github-action-to-run-tests-on-sdk branch 2 times, most recently from 8dc197b to 9cd0974 Compare September 23, 2021 10:05
@GrayedFox GrayedFox marked this pull request as ready for review September 23, 2021 10:29
@GrayedFox GrayedFox force-pushed the feature/mw-247-add-github-action-to-run-tests-on-sdk branch 4 times, most recently from 7ff1e7d to 74d3717 Compare September 27, 2021 11:26
@GrayedFox GrayedFox requested a review from nrj September 28, 2021 08:48
@GrayedFox GrayedFox force-pushed the feature/mw-247-add-github-action-to-run-tests-on-sdk branch from dd0831e to 74d3717 Compare September 28, 2021 08:58
lucaskuzma
lucaskuzma suggested changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@lucaskuzma lucaskuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one tweak please.

@GrayedFox GrayedFox force-pushed the feature/mw-247-add-github-action-to-run-tests-on-sdk branch from 74d3717 to ff85e6c Compare September 28, 2021 14:33
@GrayedFox
Add github action workflow to run tests
4506746 
* add section to readme for running tests

* add toc to readme

* use dedicated xcode build action

* fix compile error by renaming function in FMAPI.swift file

* split tests into dedicated test cases

* skip filter tests during CI

* add trigger for pushes to develop
@GrayedFox GrayedFox force-pushed the feature/mw-247-add-github-action-to-run-tests-on-sdk branch from ff85e6c to 4506746 Compare September 28, 2021 14:35
@GrayedFox GrayedFox requested review from lucaskuzma and removed request for nrj September 28, 2021 14:38
@GrayedFox GrayedFox merged commit 9618043 into develop Sep 29, 2021
@GrayedFox GrayedFox deleted the feature/mw-247-add-github-action-to-run-tests-on-sdk branch September 29, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaskuzma lucaskuzma Awaiting requested review from lucaskuzma

Assignees

@GrayedFox GrayedFox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GrayedFox @lucaskuzma