Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wae demo paths #181

Merged
merged 40 commits into from
Feb 28, 2024
Merged

Wae demo paths #181

merged 40 commits into from
Feb 28, 2024

Conversation

guilhermedemouraa
Copy link
Contributor

No description provided.

@guilhermedemouraa guilhermedemouraa marked this pull request as draft February 11, 2024 06:51
@guilhermedemouraa guilhermedemouraa marked this pull request as ready for review February 16, 2024 20:34
@guilhermedemouraa
Copy link
Contributor Author

guilhermedemouraa commented Feb 16, 2024

I think that it would be cool to have this example on our website to teach folks how to create their own custom paths. I like the idea of sharing our own path used at the WAE. But I'm open to suggestions. One thing I thought that would be cool is if we take in as args row_length, row_spacing, and n_rows. So we could just make something more general...

On a more note:
I added some methods that don't seem extremely useful in the class right now (e.g., pop_last_segment, reverse_track) - My idea is that sometime soon, we will enable path planning (at least the basics such as straight lines and turns) through our UI. In that case, those extra methods will come in very handy.

Copy link
Collaborator

@Hackerman342 Hackerman342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to move the TrackBuilder class into py/examples/track_planner/track_builder.py (as noted in one comment), then I'll approve right away. If you want this in the actual farm-ng-amiga module, then we need to harden it and consider how it will be used in the codebase / apps / etc.. This is because we will want to avoid breaking backwards compatibility once it is merged, and especially once it is released

py/farm_ng/track/utils.py Outdated Show resolved Hide resolved
py/farm_ng/track/utils.py Outdated Show resolved Hide resolved
py/farm_ng/track/utils.py Outdated Show resolved Hide resolved
py/farm_ng/track/utils.py Outdated Show resolved Hide resolved
py/farm_ng/track/utils.py Outdated Show resolved Hide resolved
py/farm_ng/track/utils.py Outdated Show resolved Hide resolved
@guilhermedemouraa guilhermedemouraa merged commit 575d46a into main Feb 28, 2024
2 checks passed
@guilhermedemouraa guilhermedemouraa deleted the WAE-demo-paths branch February 28, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants