Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C++ name collision in Service grpc. #70

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix C++ name collision in Service grpc. #70

merged 1 commit into from
Jan 24, 2023

Conversation

ethanrublee
Copy link
Member

No description provided.

@ethanrublee ethanrublee requested a review from edgarriba January 24, 2023 06:27
@ethanrublee ethanrublee linked an issue Jan 24, 2023 that may be closed by this pull request
[Bug]: service grpc fails to compile in c++ #69
Closed
@Hackerman342
Copy link
Collaborator

I will edit the corresponding Python client now

@Hackerman342 Hackerman342 merged commit b0eddaa into main Jan 24, 2023
@Hackerman342 Hackerman342 deleted the service-c++-fix branch January 24, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hackerman342 Hackerman342 Hackerman342 approved these changes

@edgarriba edgarriba Awaiting requested review from edgarriba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: service grpc fails to compile in c++
2 participants
@ethanrublee @Hackerman342