Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++ name collision in Service grpc. #70

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Fix C++ name collision in Service grpc. #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protos/farm_ng/service/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import "farm_ng/core/timestamp.proto";

package farm_ng.service.proto;

service Service {
service ServiceBase {
rpc getServiceState(GetServiceStateRequest) returns (GetServiceStateReply) {}
}
Hackerman342 marked this conversation as resolved.
Show resolved Hide resolved

Expand Down
2 changes: 1 addition & 1 deletion py/farm_ng/service/service_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def __init__(self, config: ClientConfig) -> None:

# create an async connection with the server
self.channel = grpc.aio.insecure_channel(self.server_address)
self.state_stub = service_pb2_grpc.ServiceStub(self.channel)
self.state_stub = service_pb2_grpc.ServiceBaseStub(self.channel)

@property
def server_address(self) -> str:
Expand Down