Fixed editable install command to work universally with most shells #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same fix as in fastai/fastai2#80
The existing command in the README for an editable install is:
pip install -e .[dev]
.This does not work in the
zsh
shell. And since MacOS is now defaulting tozsh
, it becomes important for it to work with it as well.Changing it to:
pip install -e ".[dev]"
makes it work with bothbash
andzsh
(on ubuntu, macOS and Windows).This GitHub issue adds more light into the issue, and it's potential solutions: mu-editor/mu#852.
This comment concludes that adding double quotes is a universal solution for most platforms and shells: mu-editor/mu#852 (comment)