Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed editable install command to work universally with most shells #8

Merged
merged 2 commits into from
Feb 10, 2020

Conversation

akashpalrecha
Copy link
Contributor

This is the same fix as in fastai/fastai2#80

The existing command in the README for an editable install is: pip install -e .[dev].
This does not work in the zsh shell. And since MacOS is now defaulting to zsh, it becomes important for it to work with it as well.

Changing it to: pip install -e ".[dev]" makes it work with both bash and zsh (on ubuntu, macOS and Windows).

This GitHub issue adds more light into the issue, and it's potential solutions: mu-editor/mu#852.
This comment concludes that adding double quotes is a universal solution for most platforms and shells: mu-editor/mu#852 (comment)

@sgugger sgugger merged commit cf62e11 into fastai:master Feb 10, 2020
@sgugger
Copy link
Contributor

sgugger commented Feb 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants