-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip install -e .[dev] error in mac zsh #852
Comments
(Sigh) Just when we think we've got a consistent, universal way of installing a dev environment... FWIW it works in Windows if you use double quotes:
Does that fly in macOS as well? |
Yep, testing zsh 5.3 and bash 3.2 in macOS Mojave, |
Ok; so if someone can confirm from the Linux / Bash perspective then I think we can tweak the docs. @ntoll ? |
I have just tested |
Thanks Barry! |
|
Hah... just got in from a bunch of meetings to find this thread. Well done everyone for finding, fixing and testing..! 👍 I have to admit having a big sigh at the same point in the conversation as @tjguk. |
@DarkSuniuM good to know..! |
Good catch @carlosperate. I'm just wondering how / whether one could address "all possible CLI shell" nuances such as the one you point out. Of course we want to remove all friction from beginners, and having the documentation say I went looking at how other projects document it: Interestingly these are using single-quotes Then I tested Windows, and even though +1 |
@tmontes That's because double quotes are for string formatting, like back ticks (`) in JavaScript or f-Strings in Python export x=10
echo "${x}" # Output: 10
echo '${x}' # Output: ${x} Using single quotes, it escapes special chars, but using double quotes, it doesn't :D |
From issue #852, this is to ensure it works in the upcoming version of macOS Catalina, and other operating systems/shells.
PR raised: #878 |
I suppose that given the fact that #878 has been merged, this issue can be closed? :) |
Yes, indeed. Thanks everybody for looking into all the multiple options! |
From issue mu-editor#852, this is to ensure it works in the upcoming version of macOS Catalina, and other operating systems/shells.
Modified the command in point four (4) so that it works correctly in all operating systems. More details in this thread: mu-editor/mu#852.
Modified the command in point four (4) so that it works correctly in all operating systems. More details in this thread: mu-editor/mu#852.
When running
pip install -e .[dev]
in Z shell you get the following error:This is because (source) :
So we need to run this instead:
Normally I would have consider this a well-known or easy to find difference in a custom shell, that most developers that have installed it should be able to solve on their own.
However with yesterday's announcement that macOS Catalina will use zsh by default (https://support.apple.com/en-ca/HT208050) we should probably add a note to the dev docs.
The text was updated successfully, but these errors were encountered: