Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #LGVISIUM-51: Pip install Install compatibilty with zsh #69

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

dcleres
Copy link
Contributor

@dcleres dcleres commented Jul 29, 2024

Edited the README to make it possible to install the python packages from a zsh terminal

@dcleres dcleres added the bug Something isn't working label Jul 29, 2024
@dcleres dcleres self-assigned this Jul 29, 2024
Copy link

github-actions bot commented Jul 29, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/stratigraphy
   __init__.py8188%11
   extract.py1881880%3–482
   get_files.py19190%3–47
   line_detection.py26260%3–76
   main.py95950%3–237
src/stratigraphy/util
   boundarydepthcolumnvalidator.py412051%47, 57, 60, 81–84, 109–127, 139–148
   coordinate_extraction.py127794%31, 62, 75–76, 80, 205, 328
   dataclasses.py32391%37–39
   depthcolumn.py1946467%26, 30, 51, 57, 60–61, 85, 88, 95, 102, 110–111, 121, 138–154, 192, 229, 248–256, 267, 272, 279, 310, 315–322, 337–338, 381–423
   depthcolumnentry.py26773%12, 15, 29–30, 33, 45, 52
   description_block_splitter.py70297%24, 139
   draw.py80800%3–244
   duplicate_detection.py51510%3–146
   extract_text.py27293%38–39
   find_depth_columns.py91693%42–43, 71, 83, 176–177
   find_description.py632856%27–35, 50–63, 79–95, 172–175
   geometric_line_utilities.py86298%82, 132
   interval.py1065548%24–27, 31–34, 39, 44, 47, 57–59, 99–145, 166, 171–187
   language_detection.py18180%3–45
   layer_identifier_column.py91910%3–227
   line.py49492%25, 42, 51, 98
   linesquadtree.py46198%76
   plot_utils.py43430%3–120
   predictions.py1301300%3–272
   textblock.py74889%27, 51, 63, 75, 98, 119, 127, 155
   util.py401855%22, 40–47, 61–63, 87–88, 100–105
TOTAL182196947% 

Tests Skipped Failures Errors Time
61 0 💤 0 ❌ 0 🔥 0.946s ⏱️

@stijnvermeeren-swisstopo
Copy link
Contributor

stijnvermeeren-swisstopo commented Jul 29, 2024

I tested this with bash, and it works as well.

However, after doing a little googling, it seems that pip install -e '.[all]' is the more commonly suggested solution, and I would find that a bit easier to read as well compared to the backslashes. Is there any reason why you did not do it like that?

@dcleres
Copy link
Contributor Author

dcleres commented Jul 29, 2024

Thank you for having a look. I do not have any preference, to be honest. I have also seen both, and I agree that the backslashes do improve the readability.

@dcleres dcleres force-pushed the LGVISIUM-51-zsh-compability branch from f4733ea to 781135e Compare July 29, 2024 10:06
@dcleres dcleres linked an issue Jul 29, 2024 that may be closed by this pull request
@dcleres dcleres merged commit efc655d into main Jul 30, 2024
3 checks passed
@dcleres dcleres deleted the LGVISIUM-51-zsh-compability branch July 31, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zsh cannot interpret the square brackets
2 participants