Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added venv to gitignore and changed install command for different CLI #846

Merged
merged 2 commits into from
Sep 24, 2022

Conversation

ZhiYingSun
Copy link
Contributor

@ZhiYingSun ZhiYingSun commented Sep 22, 2022

Motivation and Context

It is easier to manage the dependencies of python projects using a virtual environment and we should add support for it in the gitignore file.

When installing dependencies using macOS, the command did not work on zsh and it took time to figure out the issue. I propose a new command that should work for bash, zsh, Command shell, and PowerShell. This should work for most operating systems.

Your Changes

Description:

  • added venv to gitignore
  • changed install command for different CLI

Type of change (select all that apply):

  • Refactoring (internal change to codebase, without changing functionality)
  • Documentation update (change that modifies or updates documentation only)

Testing

Tested the command on zsh and this discussion tested it for other CLIs.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.

@david-yz-liu david-yz-liu merged commit a7ec6ae into pyta-uoft:master Sep 24, 2022
@david-yz-liu
Copy link
Contributor

Thanks @ZhiYingSun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants