Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support clone by reference #13

Merged
merged 8 commits into from
Nov 25, 2022
Merged

feat: support clone by reference #13

merged 8 commits into from
Nov 25, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Nov 20, 2022

superseded #11
fix #10

Opening to get some feedback

The merge is not implemented (only the clone). Should we support it now or it is fine in the following PR?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this can land

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me review this .

Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
index.js Outdated Show resolved Hide resolved
@Uzlopak Uzlopak merged commit 745b30c into master Nov 25, 2022
@Uzlopak Uzlopak deleted the native branch November 25, 2022 10:06
@Eomm Eomm mentioned this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer is merged like Array
3 participants