Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server config deep merge #568

Merged
merged 3 commits into from
Dec 1, 2022
Merged

fix: server config deep merge #568

merged 3 commits into from
Dec 1, 2022

Conversation

Eomm
Copy link
Member

@Eomm Eomm commented Nov 20, 2022

requires fastify/deepmerge#13

when the developer has a custom server option and needs to customize it when running the tests, it is impossible to do it easily because the test options overwrite all the one set by the CLI arguments

@Eomm Eomm marked this pull request as ready for review November 27, 2022 13:16
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eomm
Copy link
Member Author

Eomm commented Nov 30, 2022

@fastify/plugins need another review 🙏🏽

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 9a80ea1 into master Dec 1, 2022
@Eomm Eomm deleted the fix-merge branch December 1, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants