-
-
Notifications
You must be signed in to change notification settings - Fork 30
perf: replace querystring with fast-querystring #65
Conversation
following the other prs fastify/fastify-reply-from#272 Could you please add an option to configure the querystring module to use? Like in Fastify. |
@Eomm There's already an option to support this: https://github.com/fastify/fast-proxy#querystring |
I released 1.0 and updated the pull request. |
Any updates on this pull-request? @Eomm |
Actually the remark by eomm is not solved. queryString option is an option to replace the querystring of a request it seems. But it is not an option to replace the querystring "engine" itself. |
Yes, I totally missed that. I'll update the pull request. Thanks for the correction @Uzlopak |
I added |
I think it's time to revive this pull request. Something is wrong with Github and requesting reviews. @RafaelGSS @Eomm Can you review it again please? |
I'd appreciate it if someone can approve the workflow, once again. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@mcollina I cannot release this package we should bump a major since there are 3 major versions that has been merged by automerge |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct