-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: replace querystring with fast-querystring #272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should wait until this is at a stable version (v1.x) before doing this. From the rapid progress @anonrig is making I don't think that's far off!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add an option to configure the querystring module to use? Like in Fastify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening a PR! Can you please add a unit test?
I removed the last commit, this is actually implemented already @mcollina https://github.com/fastify/fastify-reply-from#querystring-or-querystringsearch-requrl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm did you check how much this improved perf (if at all)?
@mcollina I didn't do a benchmark, but |
Can we decorate fastify with querystring and the plugins consume that instead of clustering the option everywhere? |
@Fdawgs I released 1.0. I think it is stable enough. |
Do we agree to release it as a minor version? |
It is a non-breaking change, if we are following sem-ver. |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct