Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register multiple Redis client instances with Typescript #103

Closed
wants to merge 3 commits into from

Conversation

CloudPower97
Copy link

Checklist

Description

Closes #102

@CloudPower97
Copy link
Author

Hi, @Eomm I'm not sure why but all of the tests are failing no matter what.

I'm using the official Redis Docker image, exposing port 6379 to the host.

But I receive the following error:

  node_modules/avvio/plugin.js                                                                       
  121 |       debug('timed out', name)                                                               
  122 |       timer = null                                                                           
> 123 |       const err = new Error(`${CODE_PLUGIN_TIMEOUT}: plugin did not start in time: ${name}. You may have forgotten to call 'done' function or to resolve a Promise`)
      | ------------------^                                                                          
  124 |       err.code = CODE_PLUGIN_TIMEOUT                                                         
  125 |       err.fn = func                                                                          
  126 |       done(err)   

Any ideas?

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unnecessary linting change and please run ``npm run lint -- --fix` before commit.

Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is missing a test here
https://github.com/fastify/fastify-redis/blob/master/test/types/index.ts

The CI is failing due the a test plan (check my suggestion)

})

test('Registering multiple Redis client instances', (t) => {
t.plan(2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.plan(2)
t.plan(3)

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkgl0w darkgl0w mentioned this pull request Sep 25, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to register multiple Redis client instances with Typescript
3 participants