-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: types and tests coverage #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Currently there are only 2 statements that are never tested (current coverage is 95.83%):
Maybe I am just too tired but my guesses are that with the way errors are handled those paths are impossible to reach and I don't think there should be |
In this case, use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor problem found after revisit the test case.
Co-authored-by: KaKa <climba03003@gmail.com>
Co-authored-by: KaKa <climba03003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks to you I found a way to force Redis to actually throw an error that we can catch in order to test those 2 statements ^^ |
@climba03003 > Concerning the Public exported |
Yes. it is fine. |
…sPluginOptions` instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hello,
closes issue #102 and closes #103 that seems to be abandoned.
fastify.redis
decorator withObject.create(null)
FastifyRedisPlugin
and useFastifyRedisPluginOptions
instead)Checklist
npm run test
andnpm run benchmark
and/or benchmarksare includeddocumentation is changed or addedand the Code of conduct