Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing option for sharedSchemaId in typings #146

Closed
wants to merge 1 commit into from
Closed

fix: missing option for sharedSchemaId in typings #146

wants to merge 1 commit into from

Conversation

sinedied
Copy link
Contributor

Oops, in my previous PR #144 I forgot to update the typings for the new added options. This PR fixes that.

Checklist

@Fdawgs Fdawgs requested review from a team September 30, 2023 07:49
gurgunday
gurgunday previously approved these changes Sep 30, 2023
View reviewed changes
mcollina
mcollina requested changes Sep 30, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this type? We use tsd

@arthurfiorette arthurfiorette mentioned this pull request Oct 11, 2023
Merged
4 tasks
@gurgunday
Copy link
Member

superseded by #147

@gurgunday gurgunday closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina requested changes

@gurgunday gurgunday gurgunday left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinedied @gurgunday @mcollina