-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve type declaration for errors #147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hey @gurgunday, is there anything else needed to merge this PR? |
I restrain from merging type PRs without 2 approvals 😁 I’ll request another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Can you please rewrite the JSDoc description to not use 'you'?
See our style guide here. :)
@Fdawgs done! I also updated examples regarding schema id to use camel case |
Signed-off-by: Arthur Fiorette <47537704+arthurfiorette@users.noreply.github.com>
Code still LGTM @Fdawgs are you ok with the change? |
This PR extends #146, as I would like to merge this as quickly as possible, I also added requested type tests and jsdoc.
This also adds exports to 3 types inside
lib/httpError
:HttpErrorCodes
,HttpErrorNames
andHttpErrors
.Thanks :)
Checklist
npm run test
andnpm run benchmark
and the Code of conduct